From 815f20519f5a3de0319f256315c2ff787b224239 Mon Sep 17 00:00:00 2001 From: Hugo Bernier Date: Sun, 20 Oct 2024 17:29:07 -0400 Subject: [PATCH] Updated readme, sample.json; devcontainer --- .../.devcontainer/devcontainer.json | 75 +++++++++---------- .../.devcontainer/spfx-startup.sh | 6 +- samples/react-accordion/.nvmrc | 1 + samples/react-accordion/README.md | 18 +---- samples/react-accordion/assets/sample.json | 10 +-- samples/react-accordion/package-lock.json | 4 +- 6 files changed, 48 insertions(+), 66 deletions(-) create mode 100644 samples/react-accordion/.nvmrc diff --git a/samples/react-accordion/.devcontainer/devcontainer.json b/samples/react-accordion/.devcontainer/devcontainer.json index edbc0aded9..43357099ed 100644 --- a/samples/react-accordion/.devcontainer/devcontainer.json +++ b/samples/react-accordion/.devcontainer/devcontainer.json @@ -1,39 +1,38 @@ -// For more information on how to run this SPFx project in a VS Code Remote Container, please visit https://aka.ms/spfx-devcontainer { - "name": "SPFx 1.10.0", - "image": "docker.io/m365pnp/spfx:1.10.0", - // Set *default* container specific settings.json values on container create. - "settings": {}, - // Add the IDs of extensions you want installed when the container is created. - "extensions": [ - "editorconfig.editorconfig", - "dbaeumer.vscode-eslint" - ], - // Use 'forwardPorts' to make a list of ports inside the container available locally. - "forwardPorts": [ - 4321, - 35729, - 5432 - ], - "portsAttributes": { - "4321": { - "protocol": "https", - "label": "Manifest", - "onAutoForward": "silent", - "requireLocalPort": true - }, - "5432": { - "protocol": "https", - "label": "Workbench", - "onAutoForward": "silent" - }, - "35729": { - "protocol": "https", - "label": "LiveReload", - "onAutoForward": "silent", - "requireLocalPort": true - } - }, - "postCreateCommand": "bash .devcontainer/spfx-startup.sh", - "remoteUser": "node" -} \ No newline at end of file + "name": "SPFx 1.20.0", + "image": "docker.io/m365pnp/spfx:1.20.0", + "customizations": { + "vscode": { + "extensions": [ + "editorconfig.editorconfig", + "dbaeumer.vscode-eslint" + ] + } + }, + "forwardPorts": [ + 4321, + 35729, + 5432 + ], + "portsAttributes": { + "4321": { + "protocol": "https", + "label": "Manifest", + "onAutoForward": "silent", + "requireLocalPort": true + }, + "5432": { + "protocol": "https", + "label": "Workbench", + "onAutoForward": "silent" + }, + "35729": { + "protocol": "https", + "label": "LiveReload", + "onAutoForward": "silent", + "requireLocalPort": true + } + }, + "postCreateCommand": "bash .devcontainer/spfx-startup.sh", + "remoteUser": "node" +} diff --git a/samples/react-accordion/.devcontainer/spfx-startup.sh b/samples/react-accordion/.devcontainer/spfx-startup.sh index ca531bdf2d..456d6aea8b 100644 --- a/samples/react-accordion/.devcontainer/spfx-startup.sh +++ b/samples/react-accordion/.devcontainer/spfx-startup.sh @@ -7,9 +7,11 @@ echo echo -e "\e[1;94mGenerating dev certificate\e[0m" gulp trust-dev-cert +# Convert the generated PEM certificate to a CER certificate +openssl x509 -inform PEM -in ~/.rushstack/rushstack-serve.pem -outform DER -out ./spfx-dev-cert.cer -cp ~/.gcb-serve-data/gcb-serve.cer ./spfx-dev-cert.cer -cp ~/.gcb-serve-data/gcb-serve.cer ./spfx-dev-cert.pem +# Copy the PEM ecrtificate for non-Windows hosts +cp ~/.rushstack/rushstack-serve.pem ./spfx-dev-cert.pem ## add *.cer to .gitignore to prevent certificates from being saved in repo if ! grep -Fxq '*.cer' ./.gitignore diff --git a/samples/react-accordion/.nvmrc b/samples/react-accordion/.nvmrc new file mode 100644 index 0000000000..bb52a169c1 --- /dev/null +++ b/samples/react-accordion/.nvmrc @@ -0,0 +1 @@ +v18.18.2 diff --git a/samples/react-accordion/README.md b/samples/react-accordion/README.md index db57b65466..218789b0c3 100644 --- a/samples/react-accordion/README.md +++ b/samples/react-accordion/README.md @@ -1,19 +1,3 @@ ---- -page_type: sample -products: -- office-sp -languages: -- javascript -- typescript -extensions: - contentType: samples - technologies: - - SharePoint Framework - platforms: - - React - createdDate: 1/8/2018 12:00:00 AM ---- - # Using React Accordion plugin with SPFx ## Summary @@ -30,7 +14,7 @@ This is a sample web Part that illustrates the use of React Accessible Accordion |Refer to for more information on SPFx compatibility. | ![SPFx 1.20.0](https://img.shields.io/badge/SPFx-1.20.0-green.svg) -![Node.js v16 | v18](https://img.shields.io/badge/Node.js-v16%20%7C%20v18-green.svg) +![Node.js v18](https://img.shields.io/badge/Node.js-v18-green.svg) ![Compatible with SharePoint Online](https://img.shields.io/badge/SharePoint%20Online-Compatible-green.svg) ![Does not work with SharePoint 2019](https://img.shields.io/badge/SharePoint%20Server%202019-Incompatible-red.svg "SharePoint Server 2019 requires SPFx 1.4.1 or lower") ![Does not work with SharePoint 2016 (Feature Pack 2)](https://img.shields.io/badge/SharePoint%20Server%202016%20(Feature%20Pack%202)-Incompatible-red.svg "SharePoint Server 2016 Feature Pack 2 requires SPFx 1.1") diff --git a/samples/react-accordion/assets/sample.json b/samples/react-accordion/assets/sample.json index 64be777c75..5eb316fee2 100644 --- a/samples/react-accordion/assets/sample.json +++ b/samples/react-accordion/assets/sample.json @@ -9,7 +9,7 @@ "This is a sample web Part that illustrates the use of React Accessible Accordion plugin for building SharePoint Framework client-side web parts to show SharePoint list data in Accordion format." ], "creationDateTime": "2020-06-22", - "updateDateTime": "2021-09-30", + "updateDateTime": "2024-10-13", "products": [ "SharePoint" ], @@ -38,17 +38,13 @@ "authors": [ { "gitHubAccount": "gautamdsheth", - "company": "Valo Intranet", "pictureUrl": "https://github.com/gautamdsheth.png", - "name": "Gautam Sheth", - "twitter": "gautamdsheth" + "name": "Gautam Sheth" }, { "gitHubAccount": "AbhishekGarg", - "company": "Atos", "pictureUrl": "https://avatars.githubusercontent.com/u/5449154?s=400\u0026v=4", - "name": "Abhishek Garg", - "twitter": "abhig89" + "name": "Abhishek Garg" } ], "references": [ diff --git a/samples/react-accordion/package-lock.json b/samples/react-accordion/package-lock.json index c3aaee6ff1..c04f1aea7a 100644 --- a/samples/react-accordion/package-lock.json +++ b/samples/react-accordion/package-lock.json @@ -1,12 +1,12 @@ { "name": "react-accordion", - "version": "2.3.0", + "version": "3.0.0", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "react-accordion", - "version": "2.3.0", + "version": "3.0.0", "dependencies": { "@fluentui/react": "8.106.4", "@microsoft/sp-core-library": "1.20.0",