Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cahing question when used with actions/setup-node@v4 #152

Open
capaj opened this issue Nov 29, 2024 · 1 comment
Open

cahing question when used with actions/setup-node@v4 #152

capaj opened this issue Nov 29, 2024 · 1 comment

Comments

@capaj
Copy link

capaj commented Nov 29, 2024

in the readme you show this setup:

      - name: Get pnpm store directory
        shell: bash
        run: |
          echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV

      - uses: actions/cache@v4
        name: Setup pnpm cache
        with:
          path: ${{ env.STORE_PATH }}
          key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
          restore-keys: |
            ${{ runner.os }}-pnpm-store-

wouldn't it be enough to use

      - name: Setup Node.js
        uses: actions/setup-node@v4
        with:
          node-version-file: '.nvmrc'
          cache: 'pnpm'

?

@capaj capaj changed the title cahing question when used with actions/setup-node@v4 cahing question when used with actions/setup-node@v4 Nov 29, 2024
@trim21
Copy link

trim21 commented Dec 2, 2024

yes, see the example here: #80 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants