From 3345bd2901c058c12b38b4c11259c7a358958cc3 Mon Sep 17 00:00:00 2001 From: forcedebug <167591285+forcedebug@users.noreply.github.com> Date: Thu, 30 Jan 2025 01:49:11 +0800 Subject: [PATCH 1/3] chore: fix some function names in comment (#1019) fix some function names in comment --- e2e/tests/node.go | 2 +- e2e/tests/reset_params_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/e2e/tests/node.go b/e2e/tests/node.go index 6620c995e..d49970d8c 100644 --- a/e2e/tests/node.go +++ b/e2e/tests/node.go @@ -187,7 +187,7 @@ func (p *pocketdBin) runPocketCmd(args ...string) (*commandResult, error) { return r, err } -// runCurlPostCmd is a helper to run a command using the local pocketd binary with the flags provided +// runCurlCmd is a helper to run a command using the local pocketd binary with the flags provided func (p *pocketdBin) runCurlCmd(rpcBaseURL, service, method, path, appAddr, data string, args ...string) (*commandResult, error) { rpcUrl, err := url.Parse(rpcBaseURL) if err != nil { diff --git a/e2e/tests/reset_params_test.go b/e2e/tests/reset_params_test.go index 404ecd176..3b0c0ab1d 100644 --- a/e2e/tests/reset_params_test.go +++ b/e2e/tests/reset_params_test.go @@ -28,7 +28,7 @@ func (s *suite) resetAllModuleParamsToDefaults() { s.sendAuthzExecTx(s.granteeName, resetTxJSONFile.Name()) } -// allMoudlesMsgUpdateParamsToDefaultsAny returns a slice of Any messages, each corresponding +// allModulesMsgUpdateParamsToDefaultsAny returns a slice of Any messages, each corresponding // to a MsgUpdateParams for a module, populated with the respective default values. func (s *suite) allModulesMsgUpdateParamsToDefaultsAny() []*codectypes.Any { s.Helper() From 08a1dd27418056f6e3cc462c0464fcd33115c260 Mon Sep 17 00:00:00 2001 From: Bryan White Date: Thu, 30 Jan 2025 14:29:08 +0100 Subject: [PATCH 2/3] refactor: migration keeper in cosmos app --- app/app.go | 4 +--- app/keepers/types.go | 2 ++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/app.go b/app/app.go index 6e9cff698..93b608d19 100644 --- a/app/app.go +++ b/app/app.go @@ -1,7 +1,6 @@ package app import ( - migrationmodulekeeper "github.com/pokt-network/poktroll/x/migration/keeper" // this line is used by starport scaffolding # stargate/app/moduleImport "io" "os" @@ -70,7 +69,6 @@ type App struct { // simulation manager sm *module.SimulationManager - MigrationKeeper migrationmodulekeeper.Keeper // this line is used by starport scaffolding # stargate/app/keeperDeclaration // Ignite CLI adds keepers here when scaffolding new modules. Please move the created keeper to the `keepers` package. } @@ -216,7 +214,7 @@ func New( &app.Keepers.ProofKeeper, &app.Keepers.TokenomicsKeeper, &app.Keepers.SharedKeeper, - &app.MigrationKeeper, + &app.Keepers.MigrationKeeper, // this line is used by starport scaffolding # stargate/app/keeperDefinition // Ignite CLI adds keepers here when scaffolding new modules. Please move the created keeper to the `keepers` package. ); err != nil { diff --git a/app/keepers/types.go b/app/keepers/types.go index 2125523c5..f169bc7ff 100644 --- a/app/keepers/types.go +++ b/app/keepers/types.go @@ -32,6 +32,7 @@ import ( applicationmodulekeeper "github.com/pokt-network/poktroll/x/application/keeper" gatewaymodulekeeper "github.com/pokt-network/poktroll/x/gateway/keeper" + migrationmodulekeeper "github.com/pokt-network/poktroll/x/migration/keeper" proofmodulekeeper "github.com/pokt-network/poktroll/x/proof/keeper" servicemodulekeeper "github.com/pokt-network/poktroll/x/service/keeper" sessionmodulekeeper "github.com/pokt-network/poktroll/x/session/keeper" @@ -82,4 +83,5 @@ type Keepers struct { ProofKeeper proofmodulekeeper.Keeper TokenomicsKeeper tokenomicsmodulekeeper.Keeper SharedKeeper sharedmodulekeeper.Keeper + MigrationKeeper migrationmodulekeeper.Keeper } From a63ea9bda09ef1259d70292c13b8968e81155aad Mon Sep 17 00:00:00 2001 From: Bryan White Date: Thu, 30 Jan 2025 14:31:06 +0100 Subject: [PATCH 3/3] chore: review feedback improvements --- proto/poktroll/migration/params.proto | 2 -- 1 file changed, 2 deletions(-) diff --git a/proto/poktroll/migration/params.proto b/proto/poktroll/migration/params.proto index b20062256..9b7b71a61 100644 --- a/proto/poktroll/migration/params.proto +++ b/proto/poktroll/migration/params.proto @@ -11,6 +11,4 @@ option (gogoproto.stable_marshaler_all) = true; message Params { option (amino.name) = "poktroll/x/migration/Params"; option (gogoproto.equal) = true; - - } \ No newline at end of file