From 5b8c093fac85c398efb8af15ec81e697251f6652 Mon Sep 17 00:00:00 2001 From: Redouane Lakrache Date: Thu, 15 Aug 2024 22:00:30 +0200 Subject: [PATCH] [SDK] Upgrade shannon sdk dependency (#736) ## Summary * Upgrade ShannonSDK dependency to use `main` which is now using the post non-custodial staking `Supplier` * _Unrelated to the PR_ Fix: Restore send relay E2E test step. ## Issue Use mainline ShannonSDK which now supports `Supplier` with `OwnerAddress` and `OperatorAddress` ## Type of change Select one or more: - [ ] New feature, functionality or library - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing **Documentation changes** (only if making doc changes) - [ ] `make docusaurus_start`; only needed if you make doc changes **Local Testing** (only if making code changes) - [x] **Unit Tests**: `make go_develop_and_test` - [x] **LocalNet E2E Tests**: `make test_e2e` - See [quickstart guide](https://dev.poktroll.com/developer_guide/quickstart) for instructions **PR Testing** (only if making code changes) - [x] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. - **THIS IS VERY EXPENSIVE**, so only do it after all the reviews are complete. - Optionally run `make trigger_ci` if you want to re-trigger tests without any code changes - If tests fail, try re-running failed tests only using the GitHub UI as shown [here](https://github.com/pokt-network/poktroll/assets/1892194/607984e9-0615-4569-9452-4c730190c1d2) ## Sanity Checklist - [x] I have tested my changes using the available tooling - [ ] I have commented my code - [ ] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [ ] I have left TODOs throughout the codebase, if applicable ## Summary by CodeRabbit - **Chores** - Updated the dependency version for the `shannon-sdk`, which may include improvements and bug fixes that enhance application performance and stability. - **New Features** - Added a verification step in the Relay Namespace test to ensure that a "ClaimSettled" event is broadcasted after a successful request, enhancing testing coverage and validating event-driven interactions. --- e2e/tests/relay.feature | 3 ++- go.mod | 2 +- go.sum | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/e2e/tests/relay.feature b/e2e/tests/relay.feature index 21609d0cc..64011ce28 100644 --- a/e2e/tests/relay.feature +++ b/e2e/tests/relay.feature @@ -13,7 +13,8 @@ Feature: Relay Namespace And the application "app1" is staked for service "rest" And the supplier "supplier1" is staked for service "rest" And the session for application "app1" and service "rest" contains the supplier "supplier1" - When the application "app1" sends the supplier "supplier1" a successful request for service "rest" with path "/quote" + When the application "app1" sends the supplier "supplier1" a successful request for service "rest" with path "/quote" + Then a "tokenomics" module "ClaimSettled" end block event is broadcast # TODO_TEST(@Olshansk): # - Successful relay through applicat's sovereign appgate server diff --git a/go.mod b/go.mod index e4c0f4080..6eaf69fc3 100644 --- a/go.mod +++ b/go.mod @@ -56,7 +56,7 @@ require ( // This is creating a circular dependency whereby exporting the protobufs into a separate // repo is the first obvious idea, but has to be carefully considered, automated, and is not // a hard blocker. - github.com/pokt-network/shannon-sdk v0.0.0-20240806142441-c21a52c209b5 + github.com/pokt-network/shannon-sdk v0.0.0-20240814144717-dfa95b525d46 github.com/pokt-network/smt v0.12.0 github.com/pokt-network/smt/kvstore/badger v0.0.0-20240109205447-868237978c0b github.com/prometheus/client_golang v1.19.0 diff --git a/go.sum b/go.sum index fe11eb4c6..f2ef7b926 100644 --- a/go.sum +++ b/go.sum @@ -994,8 +994,8 @@ github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 h1:Jamvg5psRI github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4= github.com/pokt-network/ring-go v0.1.0 h1:hF7mDR4VVCIqqDAsrloP8azM9y1mprc99YgnTjKSSwk= github.com/pokt-network/ring-go v0.1.0/go.mod h1:8NHPH7H3EwrPX3XHfpyRI6bz4gApkE3+fd0XZRbMWP0= -github.com/pokt-network/shannon-sdk v0.0.0-20240806142441-c21a52c209b5 h1:NoFeAk4y3pp+MvGyhaaRz3j8swJ5dmyQVVOXCTlkG/s= -github.com/pokt-network/shannon-sdk v0.0.0-20240806142441-c21a52c209b5/go.mod h1:1mvr4H75w3UgGwCH1B7fCHpGfwZFbsVFaohHd2vRSEU= +github.com/pokt-network/shannon-sdk v0.0.0-20240814144717-dfa95b525d46 h1:rkJa3LGPN+f/k2Vv9t09UWtgbpkMA0NLHRZDiGKPqo4= +github.com/pokt-network/shannon-sdk v0.0.0-20240814144717-dfa95b525d46/go.mod h1:Jql/lobckajY8BVHDRkQPf6zYraompTK1et78jKVi68= github.com/pokt-network/smt v0.12.0 h1:uqru/0ykC4LnBoMacakobNOd1iRK69PlohqjMtLmYNA= github.com/pokt-network/smt v0.12.0/go.mod h1:S4Ho4OPkK2v2vUCHNtA49XDjqUC/OFYpBbynRVYmxvA= github.com/pokt-network/smt/kvstore/badger v0.0.0-20240109205447-868237978c0b h1:TjfgV3vgW0zW47Br/OgUXD4M8iyR74EYanbFfN4ed8o=