Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proof] Update post-scaffolding for the Proof type #228

Closed
6 tasks
Olshansk opened this issue Nov 27, 2023 · 0 comments · Fixed by #263
Closed
6 tasks

[Proof] Update post-scaffolding for the Proof type #228

Olshansk opened this issue Nov 27, 2023 · 0 comments · Fixed by #263
Assignees
Labels
on-chain On-chain business logic protocol General core protocol related changes

Comments

@Olshansk
Copy link
Member

Objective

Origin Document

Goals

  • Prepare the codebase to implement MVP logic for SubmitProof
  • Put basic validation, plumbing and other business logic in place to make the core business logic easier
  • Do the "busy work" so we can focus on the interesting and important work of Proof submission

Deliverables

Non-goals / Non-deliverables

  • Implement the core business logic for Proffs
  • Make any business logic for Claims
  • Modify any off-chain business logic.

General deliverables

  • Comments: Add/update TODOs and comments alongside the source code so it is easier to follow.
  • Testing: Add new tests (unit and/or E2E) to the test suite.
  • Makefile: Add new targets to the Makefile to make the new functionality easier to use.
  • Documentation: Update architectural or development READMEs; use mermaid diagrams where appropriate.

Creator: @Olshansk
Co-Owners: @bryanchriswhite

@Olshansk Olshansk added protocol General core protocol related changes on-chain On-chain business logic labels Nov 27, 2023
@Olshansk Olshansk added this to the Shannon TestNet milestone Nov 27, 2023
@Olshansk Olshansk self-assigned this Nov 27, 2023
@Olshansk Olshansk added this to Shannon Nov 27, 2023
@Olshansk Olshansk moved this to 🔖 Ready in Shannon Nov 27, 2023
@Olshansk Olshansk assigned bryanchriswhite and unassigned Olshansk Dec 12, 2023
@bryanchriswhite bryanchriswhite moved this from 🔖 Ready to 🏗 In progress in Shannon Dec 13, 2023
@bryanchriswhite bryanchriswhite linked a pull request Dec 13, 2023 that will close this issue
11 tasks
@bryanchriswhite bryanchriswhite linked a pull request Jan 9, 2024 that will close this issue
10 tasks
@bryanchriswhite bryanchriswhite moved this from 🏗 In progress to 👀 In review in Shannon Jan 9, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Shannon Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-chain On-chain business logic protocol General core protocol related changes
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants