Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config] Enable gRPC listen endpoint and client connetion #259

Closed
4 tasks done
red-0ne opened this issue Dec 12, 2023 · 1 comment
Closed
4 tasks done

[Config] Enable gRPC listen endpoint and client connetion #259

red-0ne opened this issue Dec 12, 2023 · 1 comment
Assignees
Labels
off-chain Off-chain business logic relayminer Changes related to the Relayminer service Anything related to general-purpose RPC service support

Comments

@red-0ne
Copy link
Contributor

red-0ne commented Dec 12, 2023

Objective

With the current setup, Pocket nodes are not exposing any gRPC port that lets clients such as POKTRollSDK, AppGateServer or RelayMiner connect to it using a simple gRPC client.

This makes these clients require a cosmosclient.Context dependency which forces us to run them as a CosmosSDK standalone binary which is a blocker for POKTRollDSK to run as an importable library that other project could use in their own codebase.

Origin Document

image
pokt-network/helm-charts#15 (comment)

Goals

  • Prevent the SDK from being dependent on CosmosSDK's context (cosmostclient.Context)
  • Enable gRPC communication with Pocket nodes (poktrolld)
  • Be able to import the SDK without running its logic as an external binary and resorting to an HTTP server as a mean to interact with it.
  • Enable SDK to use gRPC while keeping the regular RPC client for event subscriptions.

Deliverables

Non-goals / Non-deliverables

  • Update the E2E tests to use gRPC to communicate with Pocket nodes.
  • Update poktrolld tx commands to use gRPC to submit transactions to Pocket nodes.

Creator: @red-0ne
Co-Owners: @Olshansk , @bryanchriswhite

@red-0ne red-0ne added relayminer Changes related to the Relayminer service Anything related to general-purpose RPC service support off-chain Off-chain business logic labels Dec 12, 2023
@red-0ne red-0ne added this to the Shannon TestNet milestone Dec 12, 2023
@red-0ne red-0ne self-assigned this Dec 12, 2023
@red-0ne red-0ne added this to Shannon Dec 12, 2023
@red-0ne red-0ne moved this to 🏗 In progress in Shannon Dec 12, 2023
@red-0ne red-0ne moved this from 🏗 In progress to ✅ Done in Shannon Jan 4, 2024
@red-0ne
Copy link
Contributor Author

red-0ne commented Jan 4, 2024

Closed by #284

@red-0ne red-0ne closed this as completed Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
off-chain Off-chain business logic relayminer Changes related to the Relayminer service Anything related to general-purpose RPC service support
Projects
Status: ✅ Done
Development

No branches or pull requests

1 participant