Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RelayMiner] Integrate new RelayMiner configuration #271

Closed
4 tasks done
red-0ne opened this issue Dec 13, 2023 · 1 comment
Closed
4 tasks done

[RelayMiner] Integrate new RelayMiner configuration #271

red-0ne opened this issue Dec 13, 2023 · 1 comment
Assignees
Labels
off-chain Off-chain business logic relayminer Changes related to the Relayminer

Comments

@red-0ne
Copy link
Contributor

red-0ne commented Dec 13, 2023

Objective

The current RelayMiner naive configuration file structure and parser is lacking capabilities to handle real life use cases like reverse proxy usage, server containerization and elaborate backend setups.

Origin Document

The new config discussion happened in this page:
https://www.notion.so/buildwithgrove/Actors-configs-dependencies-etc-ab9a93322b8744a2aaa089d5b4758b75?pvs=4#8eaa5c5a3f4743319cc1e8360d058be3

Final config structure proposed:
#246

pocket:
  query_node_rpc_url: tcp://localhost:36657
  query_node_grpc_url: tcp://127.0.0.1:36658
  tx_node_grpc_url: tcp://127.0.0.1:36658
signing_key_name: servicer1
proxies:
  - name: http-example
    host: 127.0.0.1
    port: 8080
    type: http 
suppliers:
  - name: ethereum
    type: http
    service_config:
      url: http://anvil.servicer:8545
      authentication:
        username: user
        password: pwd
      headers: {}
    hosts:
      - ethereum.devnet1.poktroll.com 
      - ethereum # <- this part can be added automatically.
    proxy_names:
      - http-example # when the RelayMiner server builder runs.
  - name: 7b-llm-model
    type: http
    service_config:
      url: http://llama-endpoint
    hosts:
      - 7b-llm-model.devnet1.poktroll.com 
      - 7b-llm-model # <- this part can be added automatically.
    proxy_names:
      - http-example # when the RelayMiner server builder runs.

Goals

  • Be able to parse the new config structure
  • Adapt the RelayerProxy to handle the new configuration and start the adequate servers

Deliverables

  • PR for parsing the config into the adequate structure
  • PR for adapting the RelayerProxy to use the new config

Non-goals / Non-deliverables

  • Implement additional types other than http
  • Implement authentication mechanisms beyond basic auth

General deliverables

  • Comments: Add/update TODOs and comments alongside the source code so it is easier to follow.
  • Testing: Add new tests (unit and/or E2E) to the test suite.

Creator: @red-0ne
Co-Owners: @okdas

@red-0ne red-0ne added relayminer Changes related to the Relayminer off-chain Off-chain business logic labels Dec 13, 2023
@red-0ne red-0ne added this to the Shannon TestNet milestone Dec 13, 2023
@red-0ne red-0ne self-assigned this Dec 13, 2023
@red-0ne red-0ne added this to Shannon Dec 13, 2023
@red-0ne red-0ne moved this to 🏗 In progress in Shannon Dec 13, 2023
@red-0ne
Copy link
Contributor Author

red-0ne commented Jan 4, 2024

Closed by #284

@red-0ne red-0ne closed this as completed Jan 4, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Shannon Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
off-chain Off-chain business logic relayminer Changes related to the Relayminer
Projects
Status: ✅ Done
Development

No branches or pull requests

1 participant