Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proof] Relay signature & Merkle proof validation #401

Closed
8 tasks
bryanchriswhite opened this issue Feb 29, 2024 · 1 comment
Closed
8 tasks

[Proof] Relay signature & Merkle proof validation #401

bryanchriswhite opened this issue Feb 29, 2024 · 1 comment
Assignees
Labels
on-chain On-chain business logic sequencer Changes related to the sequencer

Comments

@bryanchriswhite
Copy link
Contributor

bryanchriswhite commented Feb 29, 2024

Objective

The proof module MUST validate Merkle proofs (i.e. MsgSubmitProof#closest_merkle_proof) in its msgServer#SubmitProof() method.

Origin Document

image

Goals

  • Validate that the merkle proof's root, path, value hash match on-chain expectations.
  • Validate that the relay (proof value) request and response signatures match the application and supplier (respectively) for the given session.

Deliverables

  • A PR which implements merkle proof validation.
  • A PR which implements relay unpacking and validation.
  • A PR which adds relay_min_difficulty to the proof module.
  • A PR which implements relay minimum difficulty validation.

Non-goals / Non-deliverables

  • Refactoring outside the scope of the goals outlined in this issue.
  • Additional validation (e.g. distribution).

General deliverables

  • Comments: Add/update TODOs and comments alongside the source code so it is easier to follow.
  • Testing: Add new tests (unit and/or E2E) to the test suite.
  • Makefile: Add new targets to the Makefile to make the new functionality easier to use.
  • Documentation: Update architectural or development READMEs; use mermaid diagrams where appropriate.

Creator: @bryanchriswhite
Co-Owners:

@bryanchriswhite bryanchriswhite added sequencer Changes related to the sequencer on-chain On-chain business logic labels Feb 29, 2024
@bryanchriswhite bryanchriswhite added this to the Shannon TestNet milestone Feb 29, 2024
@bryanchriswhite bryanchriswhite self-assigned this Feb 29, 2024
@bryanchriswhite bryanchriswhite moved this to 🔖 Ready in Shannon Feb 29, 2024
@red-0ne red-0ne moved this from 🔖 Ready to 👀 In review in Shannon Mar 1, 2024
@red-0ne
Copy link
Contributor

red-0ne commented Mar 27, 2024

Closed as per #406

@red-0ne red-0ne closed this as completed Mar 27, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Shannon Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-chain On-chain business logic sequencer Changes related to the sequencer
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants