Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability] Add relays counter #643

Closed
2 of 6 tasks
bryanchriswhite opened this issue Jun 30, 2024 · 2 comments · Fixed by #644
Closed
2 of 6 tasks

[Observability] Add relays counter #643

bryanchriswhite opened this issue Jun 30, 2024 · 2 comments · Fixed by #644

Comments

@bryanchriswhite
Copy link
Contributor

bryanchriswhite commented Jun 30, 2024

Objective

Track the number of on-chain relays in addition to claims and compute units as they move through the claim/proof lifecycle (e.g. claimed, proven, expired, settled).

Origin Document

Screenshot_20240630_090229_com brave browser

Goals

  • Expose the number of relays in each lifecycle stage via observability.

Deliverables

  • A PR that adds telemetry counter calls where appropriate; i.e. claim/proof upsert/settlement/expiration.
  • A PR that updates relevant dashboards.

Non-goals / Non-deliverables

  • Introducing additional metrics or labels
  • Refactoring the telemetry pkg

General deliverables

  • Comments: Add/update TODOs and comments alongside the source code so it is easier to follow.
  • Testing: Add new tests (unit and/or E2E) to the test suite.
  • Makefile: Add new targets to the Makefile to make the new functionality easier to use.
  • Documentation: Update architectural or development READMEs; use mermaid diagrams where appropriate.

Creator: @bryanchriswhite
Co-Owners: @red-0ne

@bryanchriswhite bryanchriswhite added this to the Shannon MainNet milestone Jun 30, 2024
@bryanchriswhite bryanchriswhite self-assigned this Jun 30, 2024
@bryanchriswhite bryanchriswhite moved this to 📋 Backlog in Shannon Jun 30, 2024
@bryanchriswhite bryanchriswhite moved this from 📋 Backlog to 🔖 Ready in Shannon Jun 30, 2024
@bryanchriswhite bryanchriswhite moved this from 🔖 Ready to 🏗 In progress in Shannon Jul 1, 2024
@bryanchriswhite bryanchriswhite linked a pull request Jul 2, 2024 that will close this issue
14 tasks
@bryanchriswhite bryanchriswhite moved this from 🏗 In progress to 👀 In review in Shannon Jul 2, 2024
@Olshansk
Copy link
Member

Olshansk commented Jul 5, 2024

@bryanchriswhite Did you not do this in another PR already or is this still a remaining open item?

@bryanchriswhite
Copy link
Contributor Author

@bryanchriswhite Did you not do this in another PR already or is this still a remaining open item?

This is done in #644 which is still in review.

@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Shannon Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants