You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Originally posted in #20631 but it may be better in a separate issue.
It seems to me that .show_graph() becomes quite complicated by returning various output types depending on the arguments (and #20631 also adds some complexity). It's also not very clear from the outside how those arguments interact. For example if I read
then it's not clear to me what I should expect (the current behavior would be to ignore show and output_path).
Since to_dot() and to_mermaid() already exist (or will exist) on the Rust side, wouldn't it be better to have the following function signatures in Python?
Originally posted in #20631 but it may be better in a separate issue.
It seems to me that
.show_graph()
becomes quite complicated by returning various output types depending on the arguments (and #20631 also adds some complexity). It's also not very clear from the outside how those arguments interact. For example if I readthen it's not clear to me what I should expect (the current behavior would be to ignore
show
andoutput_path
).Since
to_dot()
andto_mermaid()
already exist (or will exist) on the Rust side, wouldn't it be better to have the following function signatures in Python?The text was updated successfully, but these errors were encountered: