Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch away from positional arguments #144

Open
michielbdejong opened this issue Aug 26, 2022 · 0 comments
Open

Switch away from positional arguments #144

michielbdejong opened this issue Aug 26, 2022 · 0 comments

Comments

@michielbdejong
Copy link
Member

The .pj file format was working well for me with positional arguments, but now that we're using PreJournal with more people, and using API calls to execute commands, which was also something I hadn't originally thought through, it's probably time to redesign this...

For a REST API, an object in a JSON request body would be much better practice than a array-of-strings, of course, and as we use for instance the worked-hours command in several different ways, we really need the flexibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant