Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on pointer-star alignment for function return types #247

Open
lhearachel opened this issue Sep 5, 2023 · 3 comments
Open

Decide on pointer-star alignment for function return types #247

lhearachel opened this issue Sep 5, 2023 · 3 comments
Labels

Comments

@lhearachel
Copy link
Contributor

lhearachel commented Sep 5, 2023

We already have consensus on pointer-star alignment for variable declarations, e.g.:

Pokemon *mon;
void ZeroMonData(Pokemon *mon);

I don't see any consensus on pointer-star alignment for function return types. Three options:

Pokemon * AllocMonZeroed(u32 heapID);
// vs
Pokemon* AllocMonZeroed(u32 heapID);
// vs
Pokemon *AllocMonZeroed(u32 heapID);
@red031000
Copy link
Member

IMO this (and all pointer star alignments) should be the same as we already decided

Copy link

This issue has had no activity for 60 days and will be marked stale. If there is no further activity, it will be closed in 30 days.

Copy link

github-actions bot commented Nov 1, 2024

This issue has had no activity for 60 days and will be marked stale. If there is no further activity, it will be closed in 30 days.

@github-actions github-actions bot added the stale label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants