Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate the usage of the resourceName label in generic resources #671

Open
ChristianZaccaria opened this issue Oct 23, 2023 · 0 comments · May be fixed by #652
Open

Evaluate the usage of the resourceName label in generic resources #671

ChristianZaccaria opened this issue Oct 23, 2023 · 0 comments · May be fixed by #652

Comments

@ChristianZaccaria
Copy link
Contributor

WHY

The resourceName label in the generic resources seems to be set but not used.

WHAT

Investigate/Evaluate the usage of this label, and if nothing breaks after the removal of this label.

HOW

The label is found in this file:

multi-cluster-app-dispatcher/pkg/controller/queuejobresources/genericresource/genericresource.go

Line 47 in b420be0

var resourceName = "resourceName"

Related PRs

#652
#665
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Project CodeFlare Sprint Board
Status: No status
Milestone
No milestone
1 participant
@ChristianZaccaria