From d8744d668b80355c06e1c9efff7167cbf472c0f0 Mon Sep 17 00:00:00 2001 From: Peter Snider Date: Sun, 27 Mar 2022 17:54:19 -0700 Subject: [PATCH] clean up; no functional changes --- ReadMe.md | 12 ++++++------ ....bundle.js => app.2a33eb2b9c39d82e4716.bundle.js} | 0 dist/index.html | 2 +- src/AnswerDifficulty.ts | 3 +-- src/AnswerScores.ts | 2 +- src/AnswersPanel.ts | 1 - src/InProcessIndicator.ts | 1 - src/app.ts | 4 +--- src/expiring-messages.ts | 1 - src/jsfiddles.md | 3 ++- 10 files changed, 12 insertions(+), 17 deletions(-) rename dist/{app.f8fb41402d0db25cc1c0.bundle.js => app.2a33eb2b9c39d82e4716.bundle.js} (100%) diff --git a/ReadMe.md b/ReadMe.md index 4b2a829..f543aec 100644 --- a/ReadMe.md +++ b/ReadMe.md @@ -141,15 +141,15 @@ Note that the TypeScript is in the sibling file of the same basename. Since this was a project for me to learn Aurelia, I didn't get around to writing tests. -If this web-app winds up being something that I use for a production deployment, then I'll add appropriate tests then. -In the meantime, I'll revisit both the ReactJS and Vue.js web-apps, and I may even consider other frameworks, such as Svelte and Hyper-HTML. +If this web-app winds up being something that I use for a production deployment, then I'll add appropriate tests. +In the meantime, I'll revisit both the ReactJS and Vue.js web-apps, and I may even consider other frameworks, such as Svelte or Hyper-HTML. (I've used both Angular 1 and 2 in the past, and find them too complicated.) ## Two main test categories I like to divide tests into two groups: -- independent of the network +- those independent of the network These test all normal computation, and use mocks to test local code. -- requires the internet -This may have dependencies on external services, which may fail. +- those that require the internet +These may have dependencies on external services, which may fail. I like test frameworks that support alternatives to pass/fail. For example, mocha support skip(), which causes tests to show up in test results, but as not having been run. @@ -171,5 +171,5 @@ Errors in required filenames are not flagged. This can cause a fair bit of pain The project moves along very slowly. This is the 3rd time I tried Aurelia! Both of the previous times, my project wound up dying due to tooling and documentation problems. - It's easy to confuse Aurelia v1 and v2 documentation. -But this is also true of React JS and Vue.js, which both have a number of complicating revisions and usage models. +But this is also true of React JS and Vue.js, and probably even worse. Both have a number of complicating revisions and usage models. diff --git a/dist/app.f8fb41402d0db25cc1c0.bundle.js b/dist/app.2a33eb2b9c39d82e4716.bundle.js similarity index 100% rename from dist/app.f8fb41402d0db25cc1c0.bundle.js rename to dist/app.2a33eb2b9c39d82e4716.bundle.js diff --git a/dist/index.html b/dist/index.html index f31a8b1..c2d4cdf 100644 --- a/dist/index.html +++ b/dist/index.html @@ -1 +1 @@ -License Plate Game \ No newline at end of file +License Plate Game \ No newline at end of file diff --git a/src/AnswerDifficulty.ts b/src/AnswerDifficulty.ts index 93642ae..8b0f6cf 100644 --- a/src/AnswerDifficulty.ts +++ b/src/AnswerDifficulty.ts @@ -1,5 +1,4 @@ -import {bindable, autoinject, observable} from 'aurelia-framework'; -import type { PuzzleAnswer } from "./lib/index.d" +import {bindable, autoinject} from 'aurelia-framework'; @autoinject diff --git a/src/AnswerScores.ts b/src/AnswerScores.ts index d5aa7a0..cd306b1 100644 --- a/src/AnswerScores.ts +++ b/src/AnswerScores.ts @@ -1,4 +1,4 @@ -import {bindable, autoinject, observable} from 'aurelia-framework'; +import {bindable, autoinject} from 'aurelia-framework'; @autoinject diff --git a/src/AnswersPanel.ts b/src/AnswersPanel.ts index e2a9940..f9d81e9 100644 --- a/src/AnswersPanel.ts +++ b/src/AnswersPanel.ts @@ -1,7 +1,6 @@ import {autoinject, bindable, observable} from 'aurelia-framework'; import {EventAggregator} from 'aurelia-event-aggregator'; import type { PuzzleAnswer } from "./lib" -import {AuMsgAnswersPanelState} from './messages'; @autoinject diff --git a/src/InProcessIndicator.ts b/src/InProcessIndicator.ts index 9c8cb7b..db36d4f 100644 --- a/src/InProcessIndicator.ts +++ b/src/InProcessIndicator.ts @@ -1,4 +1,3 @@ -import {bindable} from 'aurelia-framework'; export class InProcessIndicator { diff --git a/src/app.ts b/src/app.ts index fc5922f..0fbad0b 100644 --- a/src/app.ts +++ b/src/app.ts @@ -1,10 +1,8 @@ import {autoinject} from 'aurelia-framework'; import {EventAggregator} from 'aurelia-event-aggregator'; -// import {Router, RouterConfiguration} from 'aurelia-router'; -// import {PLATFORM} from 'aurelia-pal'; import {Settings, ExpiringMessage, PuzzleAnswer} from "./lib/index.d" import {MAX_EXPIRATION_SECONDS} from "./lib/lib" -import {AuMsgAboutPanelState, AuMsgFeedbackPanelState, AuMsgRemoteCallState, AuMsgNewGameRequest, AuMsgCheckAnswer, AuMsgHintRequest, AuMsgResetPuzzleText} from './messages'; +import {AuMsgAboutPanelState, AuMsgFeedbackPanelState, AuMsgRemoteCallState, AuMsgNewGameRequest, AuMsgCheckAnswer, AuMsgHintRequest} from './messages'; import {LicensePlatePuzzle} from "./lib/license-plate-puzzle" import {LicensePlateGameClient} from "license-plate-game-api" import type {LicensePlateGameAPI} from "license-plate-game-api" diff --git a/src/expiring-messages.ts b/src/expiring-messages.ts index 6572f6d..e54ddc0 100644 --- a/src/expiring-messages.ts +++ b/src/expiring-messages.ts @@ -1,4 +1,3 @@ -import { ids } from "webpack" import type {ExpiringMessage} from "./lib/index.d" import {MAX_EXPIRATION_SECONDS} from "./lib/lib" diff --git a/src/jsfiddles.md b/src/jsfiddles.md index 2fd4d26..12c2ac9 100644 --- a/src/jsfiddles.md +++ b/src/jsfiddles.md @@ -1,3 +1,4 @@ - sliding text transition https://jsfiddle.net/3zp19wjq/1/ -- blurring texxt +- blurring text + ...