Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale issue #288

Open
Joe-song-77 opened this issue Oct 16, 2020 · 2 comments
Open

Locale issue #288

Joe-song-77 opened this issue Oct 16, 2020 · 2 comments

Comments

@Joe-song-77
Copy link

Joe-song-77 commented Oct 16, 2020

See method Locales.addLocale in locales.js, the key was language. But, the window.navigator.language will give 'zh-tw' if I choose device language as 'Chinese, Traditional(Taiwan)' and region as China mainland. It will let the declared locale 'zh-TW' can't be found. So, not sure if the lowercase language should be used as the key. E,g, locales[localeObject.language.toLowerCase()] = localeObject;

Also, I just wonder if the locale 'zh-cn', 'hu' and 'nb' can be provided by default.

Could you please evaluate this? Thanks!

@westonganger
Copy link
Collaborator

Feel free to create PR's for the additional locales and for the lowercase fix.

@benjamincreativedk
Copy link

Have same issue when using customLocal these lines are ignored:
yesButtonLabel: "Ja!", noButtonLabel: "Ikke rigtigt", appRatePromptTitle: 'Kan du lide %@?',
I know they don't exists in the locales.js for "da", like Joe-song-77 mentions about Chinese. But it looks like it can't be overruled by customLocal: {} ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants