Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we clean up the benchmark history? #6

Open
kandersolar opened this issue Mar 16, 2023 · 1 comment
Open

Should we clean up the benchmark history? #6

kandersolar opened this issue Mar 16, 2023 · 1 comment

Comments

@kandersolar
Copy link
Member

The benchmark results history is getting a bit confusing. The plots are supposed to quickly draw the eye to performance jumps, but the majority of jumps are just due to environment changes. Example: SolarPositionNumba.time_sun_rise_set_transit_spa

Although changes in performance due to environment is surely interesting, I think the main goal for our benchmarks should be for evaluating performance changes in pvlib itself (holding the environment ~constant). Should we wipe out and rebuild the history using the current set of environments?

We may also want to change our environment management strategy to reduce future fragmentation.

@cwhanse
Copy link
Member

cwhanse commented Mar 16, 2023

Hard to decipher with that many traces. Do we need the 3 time options (1, 10, 100 days)? I agree that the main purpose is to track changes in pvlib code performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants