handle local echo with serialserver not working? #2414
-
I'm not sure if this is a bug or if I'm doing something wrong. I noticed that even though I have set handle_local_echo to True in the debug logs no mention of 'recv skipping (local_echo)' is found. See logs below, this is a log where also the communication breaks. pymodbus 3.7.4 logs
Now I have modified pymodbus to add the handle local echo to the commparams and everything works correctly and the echo is mentioned in the logs. Changes can be found here Modified pymodbus logs
This is how I start the serialserver
So is this a bug? Or am doing something wrong with the serialserver? |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments 2 replies
-
Your patch looks correct, it is very likely we never really considered local echo for the server. Please submit your changes as a patch, so that other can benefit from your work. |
Beta Was this translation helpful? Give feedback.
-
To be honest, we think of the server as a test tool, so a number of the "real life" problems do not pass our minds, however thanks to contributors like you they get solved, |
Beta Was this translation helpful? Give feedback.
Your patch looks correct, it is very likely we never really considered local echo for the server.
Please submit your changes as a patch, so that other can benefit from your work.