Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename theta and phi to azimuth and incident/takeoff/emergence #97

Open
miili opened this issue Jan 12, 2023 · 2 comments
Open

Rename theta and phi to azimuth and incident/takeoff/emergence #97

miili opened this issue Jan 12, 2023 · 2 comments

Comments

@miili
Copy link
Member

miili commented Jan 12, 2023

Naming the LOS angles theta and phi was a really awful idea.

We should use clear naming for the angles: azimuth and emergence
@hvasbath
Copy link
Member

I agree, however, I would rather opt for heading instead of azimuth, emergence would be ok for me.

@miili
Copy link
Member Author

miili commented Apr 11, 2023

Heading can be a little misleading since we are looking at the reference system (point of observation) of the satellite. Azimuth on the other hand implies a spherical coordinate system. Maybe @hsudha has an opinion on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miili @hvasbath