-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid erroring from tracing #424
Comments
Let's steal the safe repr from pytest |
@RonnyPfannschmidt You mean Is this open for PRs? Any guidance on where the code should go is much appreciated. |
Absolutely |
For now it can just go to the private tracing module |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A user reported a weird condition in which pluggy tracing was making their code fail after we enabled tracing because one of the local objects didn't have a working
__repr__
(a scikit-learn object from a very old version). Details: kedro-org/kedro#2630We gave the user a workaround and also it's reasonable to expect that objects have a working
__repr__
, but it would be nice if there was a generoustry ... except
around the tracing messages so that errors there don't bubble up. Essentially the same that happens with logging:The text was updated successfully, but these errors were encountered: