Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to add screenshot to report when result is ERROR #838

Open
vladimir-popescu-idnow opened this issue Oct 26, 2024 · 2 comments
Open

How to add screenshot to report when result is ERROR #838

vladimir-popescu-idnow opened this issue Oct 26, 2024 · 2 comments

Comments

@vladimir-popescu-idnow
Copy link

vladimir-popescu-idnow commented Oct 26, 2024

Hello,

I have an automation framework with selenium/pytest with some fixtures in the test modules which execute repetitive code.
In case the execution fails in the fixture this is marked as ERROR in the html report and despite being able to take a screenshot on this occurrence it is not attached to the report.
A few more details :

  • report.when == "setup"
  • report.failed is True
  • the extraHTML div is empty in the report
  • the same mechanism is used to attach the screenshot successfully if the failure occurs in the test code.

Example test & fixture

@pytest.fixture(autouse=True)
def open_userdata_page(vi_rewrite_gui):
    """
    Autouse fixture which opens userdata page before each test
    """
    vi_rewrite_gui.open_userdata_page(shortname)


def test_validation_errors(vi_rewrite_gui):
    """
    Check validation errors when trying to proceed without filling any info
    """
    vi_rewrite_gui.click_continue_btn()
    actual_validation_errors = vi_rewrite_gui.get_validation_errors()
    assert expected_validation_errors == actual_validation_errors

Conftest hook

@pytest.mark.hookwrapper
def pytest_runtest_makereport(item):

    pytest_html = item.config.pluginmanager.getplugin('html')
    outcome = yield
    report = outcome.get_result()
    report.description = str(item.function.__doc__)
    extra = getattr(report, 'extra', [])
    if report.when == 'call' or report.when == "setup":
        xfail = hasattr(report, 'wasxfail')
        if (report.skipped and xfail) or (report.failed and not xfail):
            driver = DRIVER_REGISTRY.get(item.nodeid)
            if driver:
                # driver = item.funcargs['driver_mod']
                timestamp = datetime.now().strftime('%Y-%m-%d_%H-%M-%S')
                screenshot_name = f"{item.name}_{timestamp}.png"
                driver.save_screenshot(os.path.join(SCREENSHOTS_PATH, screenshot_name))
                build_img_path_and_div_for_html(screenshot_name, extra, pytest_html)
        report.extra = extra

report

@vladimir-popescu-idnow vladimir-popescu-idnow changed the title How to add screenshot to report when status is ERROR How to add screenshot to report when result is ERROR Oct 26, 2024
@vladimir-popescu-idnow
Copy link
Author

The function build_img_path_and_div_for_html does the extra.append

def build_img_path_and_div_for_html(filename, extra, pytest_html):
    rel_path = "screenshots/" + filename
    extra.append(pytest_html.extras.html(
        f'<div class="image"><img src="{rel_path}"/></div>')
    )

I've also tried the following way with the same result

driver = DRIVER_REGISTRY.get(item.nodeid, {}).get("driver_mod")
            if driver:
                # driver = item.funcargs['driver_mod']
                timestamp = datetime.now().strftime('%Y-%m-%d_%H-%M-%S')
                screenshot_name = f"{item.name}_{timestamp}.png"
                driver.save_screenshot(os.path.join(SCREENSHOTS_PATH, screenshot_name))
                # build_img_path_and_div_for_html(screenshot_name, extra, pytest_html)
                rel_path = "screenshots/" + screenshot_name
                extra.append(pytest_html.extras.image(rel_path))

@vladimir-popescu-idnow
Copy link
Author

Any help on this one please ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant