Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels for custom metadata #412

Open
tiran opened this issue Sep 13, 2024 · 1 comment
Open

Add labels for custom metadata #412

tiran opened this issue Sep 13, 2024 · 1 comment

Comments

@tiran
Copy link
Collaborator

tiran commented Sep 13, 2024

Should we add a label system like Kubernetes's labels to Fromager? Labels could be used to provide metadata in package .yaml files. Users can add labels to packages and plugins can act upon the presence and value of a label.

Questions:

  • dict[str, str] or dict[str, typing.Any]?
  • labels in package settings? or should variants have labels, too?
  • global labels in settings.yaml?

Use case:

Declare that a package contains GPU specific code

# torch.yaml`
labels:
    gpu_specific: true
@dhellmann
Copy link
Member

I'm not clear how the example you give is useful. What plugin code would look at labels and not already know that a package has GPU-specific code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants