Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package setting to disable network isolation #433

Open
tiran opened this issue Sep 18, 2024 · 0 comments
Open

Add package setting to disable network isolation #433

tiran opened this issue Sep 18, 2024 · 0 comments
Labels
easy easy task enhancement New feature or request

Comments

@tiran
Copy link
Collaborator

tiran commented Sep 18, 2024

In Fromager 0.31, network isolation is a global, process wide setting. There are cases where we want to disable network isolation for a specific package, because we know that a specific package does not build with network isolation. With a new package setting, we could disable network isolation for a package. It would also help us to discover if other packages later in the pipeline fail with network isolation

class BuildOptions(pydantic.BaseModel):
    network_isolation: bool | None = None
  • None: use global settings
  • False: force network isolation off
  • True: force network isolation on IFF the system supports it
@tiran tiran added enhancement New feature or request easy easy task labels Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy easy task enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant