Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused arguments from default functions #483

Open
shubhbapna opened this issue Oct 22, 2024 · 0 comments · May be fixed by #517
Open

remove unused arguments from default functions #483

shubhbapna opened this issue Oct 22, 2024 · 0 comments · May be fixed by #517
Assignees
Labels

Comments

@shubhbapna
Copy link
Collaborator

we had been keeping all arguments in default functions to enable backward compatibility for plugins. However we have invoke method now that ensures that plugin functions are called with the right parameters so we can remove these arguments from the default functions.

Having unused arguments adds maintenance load and will make confusing for new contributors

@rd4398 rd4398 self-assigned this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants