Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an explicit error for return code -9 #86

Open
ebolyen opened this issue Jan 29, 2018 · 4 comments
Open

Add an explicit error for return code -9 #86

ebolyen opened this issue Jan 29, 2018 · 4 comments

Comments

@ebolyen
Copy link
Member

ebolyen commented Jan 29, 2018

Current Behavior
This seems to be always be a SIGKILL event which is almost always because of an OOM error.

Proposed Behavior
It is probably worth just catching and raising an error about SIGKILL/Memory when it happens.

@benjjneb
Copy link
Collaborator

Why are these OOM errors happening so much in the Q2 plugin? We have rarely gotten such reports on the R side. I think the only times I remember it happening are when people were using 32-bit R.

@ebolyen
Copy link
Member Author

ebolyen commented Jan 29, 2018

I suspect a lot of people are using VirtualBox, which needs to be configured ahead of time to have an even remotely reasonable amount of memory.

@benjjneb
Copy link
Collaborator

Ah, that makes sense.

So to implement this, the -9 exit code would need to be caught from Python where it makes the Rscript call?

@ebolyen
Copy link
Member Author

ebolyen commented Jan 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants