feat: add force ica send governance message type #1712

joe-bowman · 2024-08-15T13:38:04Z

1. Summary

2.Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

3. Implementation details

Add a new governance type that permits funds to be MsgSend from an ICA account to another account, subject to the following constraints.

Source account must be a valid ICA.
Destination account must be a valid account on the same network.
From must be the governance authority.

TODO:

Tests

vercel · 2024-08-15T13:38:08Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
quicksilver	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 15, 2024 1:39pm

coderabbitai · 2024-08-15T13:38:14Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

x/interchainstaking/keeper/zones.go

+	}
+	data := banktypes.CreateAccountBalancesPrefix(addr)
+
+	icaAccount, err := k.GetICAAccount(ctx, &zone, address)


codecov · 2024-08-15T13:52:42Z

Codecov Report

Attention: Patch coverage is 12.90323% with 54 lines in your changes missing coverage. Please review.

Project coverage is 63.82%. Comparing base (efda503) to head (db59101).
Report is 45 commits behind head on main.

Files with missing lines	Patch %	Lines
x/interchainstaking/keeper/msg_server.go	0.00%	25 Missing ⚠️
x/interchainstaking/types/msgs.go	0.00%	23 Missing ⚠️
x/interchainstaking/keeper/zones.go	57.14%	4 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1712      +/-   ##
==========================================
- Coverage   64.04%   63.82%   -0.23%     
==========================================
  Files         196      196              
  Lines       13961    14000      +39     
==========================================
- Hits         8942     8935       -7     
- Misses       4164     4211      +47     
+ Partials      855      854       -1

Flag	Coverage Δ
unittests	`63.82% <12.90%> (-0.23%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
x/interchainstaking/keeper/zones.go	`63.75% <57.14%> (+0.60%)`	⬆️
x/interchainstaking/types/msgs.go	`80.08% <0.00%> (-8.76%)`	⬇️
x/interchainstaking/keeper/msg_server.go	`82.84% <0.00%> (-6.62%)`	⬇️

joe-bowman · 2024-08-30T00:43:39Z

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

joe-bowman · 2024-11-22T00:51:26Z

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

joe-bowman · 2024-12-07T00:52:11Z

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

joe-bowman · 2024-12-23T00:50:08Z

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

feat: add force ica send governance message type

db59101

vercel bot temporarily deployed to Preview August 15, 2024 13:39 Inactive

github-advanced-security bot found potential problems Aug 15, 2024

View reviewed changes

x/interchainstaking/keeper/zones.go

}

data := banktypes.CreateAccountBalancesPrefix(addr)

icaAccount, err := k.GetICAAccount(ctx, &zone, address)

Check warning

Code scanning / CodeQL

Useless assignment to local variable Warning

This definition of err is never used.

joe-bowman added Stale and removed Stale labels Aug 30, 2024

joe-bowman added Stale and removed Stale labels Nov 22, 2024

joe-bowman added Stale and removed Stale labels Dec 7, 2024

joe-bowman added the Stale label Dec 23, 2024

joe-bowman closed this Dec 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add force ica send governance message type #1712

feat: add force ica send governance message type #1712

joe-bowman commented Aug 15, 2024

vercel bot commented Aug 15, 2024 •

edited

Loading

coderabbitai bot commented Aug 15, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

codecov bot commented Aug 15, 2024 •

edited

Loading

joe-bowman commented Aug 30, 2024

joe-bowman commented Nov 22, 2024

joe-bowman commented Dec 7, 2024

joe-bowman commented Dec 23, 2024

feat: add force ica send governance message type #1712

feat: add force ica send governance message type #1712

Conversation

joe-bowman commented Aug 15, 2024

1. Summary

2.Type of change

3. Implementation details

vercel bot commented Aug 15, 2024 • edited Loading

coderabbitai bot commented Aug 15, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

codecov bot commented Aug 15, 2024 • edited Loading

Codecov Report

joe-bowman commented Aug 30, 2024

joe-bowman commented Nov 22, 2024

joe-bowman commented Dec 7, 2024

joe-bowman commented Dec 23, 2024

vercel bot commented Aug 15, 2024 •

edited

Loading

coderabbitai bot commented Aug 15, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Aug 15, 2024 •

edited

Loading