Test relies on {tibble} in an opaque way

[MichaelChirico]

fs/tests/testthat/test-file.R

Line 42 in 8d40528

expect_s3_class(x, "tbl_df")

Recent update of {waldo} to drop {tibble} as a required package caused this test to break for us (because now {tibble} needs to be included intentionally for testing).

The failure mode is pretty opaque:

══ Failed tests ════════════════════════════════════════════════════════════════
── Failure (test-file.R:42:7): file_info: can be subset as a tibble ────────────
`x` inherits from 'data.frame' not 'tbl_df'.

Suggestions:

1. skip_if_not_installed("tibble")
2. Write requireNamespace("tibble") clearly in the test body to make the connection to {tibble} crystal clear
3. Use withr::local_options(list(fs.use_tibble=FALSE)) to make this test independent of {tibble}:

fs/R/utils.R

Lines 135 to 139 in 8d40528

	if (getOption("fs.use_tibble", TRUE) && is_installed("tibble")) {
	tibble::as_tibble(x)
	} else {
	x
	}