New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support additive rollups #36

Open

rahulsom opened this issue Aug 4, 2017 · 0 comments

Labels

Owner

rahulsom commented Aug 4, 2017 •

edited

Loading

Currently rollups are computed as

departmentEmployeeJoin
   .computeSnapshot(id, dateOrVersion)
   .flatMap { fromIterator(it.joinedIds) }
   .flatMap { employeeQuery.computeSnapshot(it) }
   .reduce (new DepartmentSummary()) { rollup, snapshot -> ... }

There isn't much potential to do this additively.

If we can do it differently, and this works, we could try this

departmentEmployeeJoin
   .computeSnapshot(id, dateOrVersion)
   .flatMap { getAllEventsForAfterDateOrVersion(it.joinedIds, dateOrVersion) }
   .reduce (new DepartmentSummary()) {rollup, event -> ... }

The challenge is reducing

The number of events fetched
The number of computations performed
The number of scenarios requiring a full recompute

rahulsom added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment