From ca7c5419c59b2879c54cf2bbd3e645813b5e5fa8 Mon Sep 17 00:00:00 2001 From: Ranieri Althoff Date: Sat, 4 Nov 2023 22:51:17 +0100 Subject: [PATCH] Raise minimum Node version to 18 --- .github/workflows/ci.yml | 6 +++--- .github/workflows/release.yml | 18 +++++++++--------- README.md | 6 +++--- 3 files changed, 15 insertions(+), 15 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 99a3ad3..918f5c5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -11,7 +11,7 @@ jobs: test: strategy: matrix: - node-version: [16, 18, 20] + node-version: [18, 20] os: [ubuntu-20.04, macos-11, macos-m1, windows-2019] name: Test for node-${{ matrix.node-version }} on ${{ matrix.os }} @@ -59,7 +59,7 @@ jobs: name: Test on Alpine Linux runs-on: ubuntu-latest container: - image: node:16-alpine + image: node:18-alpine steps: - name: Install build deps @@ -79,7 +79,7 @@ jobs: test-freebsd: strategy: matrix: - node-version: [16, 18, 20] + node-version: [18, 20] name: Test for node-${{ matrix.node-version }} on FreeBSD runs-on: macos-12 diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 3eb3bab..9b6aef2 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -18,11 +18,11 @@ jobs: with: submodules: true - - name: Use Node.js 16 + - name: Use Node.js 18 uses: actions/setup-node@v3 with: cache: yarn - node-version: 16 + node-version: 18 registry-url: https://registry.npmjs.org/ - name: Install dependencies @@ -47,11 +47,11 @@ jobs: with: submodules: true - - name: Use Node.js 16 + - name: Use Node.js 18 uses: actions/setup-node@v3 with: cache: yarn - node-version: 16 + node-version: 18 - name: Install dependencies run: yarn install --frozen-lockfile @@ -70,7 +70,7 @@ jobs: name: Build on Alpine Linux runs-on: ubuntu-latest container: - image: node:16-alpine + image: node:18-alpine steps: - name: Install build deps @@ -111,7 +111,7 @@ jobs: with: submodules: true - - uses: uraimo/run-on-arch-action@v2.2.0 + - uses: uraimo/run-on-arch-action@v2 name: Package artifacts id: build with: @@ -126,13 +126,13 @@ jobs: ubuntu*|jessie|stretch|buster) apt-get update -y apt-get install -y curl - curl -fsSL https://deb.nodesource.com/setup_16.x | bash - + curl -fsSL https://deb.nodesource.com/setup_18.x | bash - apt-get install -y make g++ python nodejs npm install --global yarn ;; alpine*) apk add --update make g++ python3 - apk add --no-cache --repository https://dl-cdn.alpinelinux.org/alpine/v3.15/main/ nodejs~=16 npm + apk add --no-cache --repository https://dl-cdn.alpinelinux.org/alpine/v3.17/main/ nodejs~=18 npm npm install --global yarn ;; esac @@ -163,7 +163,7 @@ jobs: with: envs: 'npm_config_build_from_source' prepare: | - pkg install -y gmake python3 yarn-node16 + pkg install -y gmake python3 yarn-node18 run: | yarn install --frozen-lockfile yarn node-pre-gyp package diff --git a/README.md b/README.md index 6be0f2e..795523b 100644 --- a/README.md +++ b/README.md @@ -68,7 +68,7 @@ The current prebuilt binaries are built and tested with the following systems: - MacOS 11 (x86-64) - MacOS 12 (ARM64 from v0.29.0) - Windows Server 2019 (x86-64) -- Alpine Linux 3.13 (x86-64 from v0.28.1; ARM64 from v0.28.2) +- Alpine Linux 3.17+ (x86-64 from v0.28.1; ARM64 from v0.28.2) - FreeBSD 13.1 (x86-64 from v0.29.1) Binaries should also work for any version more recent than the ones listed @@ -86,7 +86,7 @@ You **MUST** have a **node-gyp** global install before proceeding with the insta along with GCC >= 5 / Clang >= 3.3. On Windows, you must compile under Visual Studio 2015 or newer. -**node-argon2** works only and is tested against Node >=14.0.0. +**node-argon2** works only and is tested against Node >=18.0.0. ### OSX To install GCC >= 5 on OSX, use [homebrew](http://brew.sh/): @@ -149,7 +149,7 @@ you'll need to specify that in the command. I installed Node as a snap, and I can't install node-argon2. - + This seems to be an issue related to snap (see [#345 (comment)](https://github.com/ranisalt/node-argon2/issues/345#issuecomment-1164178674)). Installing Node with another package manager, such as [asdf](https://asdf-vm.com/) or [nvm](https://github.com/nvm-sh/nvm), is a possible workaround.