Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating pylibraft pairwise_distance to cuvs #8847

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Dec 19, 2024

This PR updates cupy so that it can make use of the cuvs library for pairwise distance, which the vector search APIs from pylibraft have recently moved. This PR maintains the backwards compatibility with pylibraft while will exposing double precision float support.

Closes rapidsai/cuvs#542

@leofang
Copy link
Member

leofang commented Dec 20, 2024

I assume these two files will need to change too, in order to test this in the CI:

@leofang leofang added the to-be-backported Pull-requests to be backported to stable branch label Dec 20, 2024
@kmaehashi kmaehashi self-assigned this Dec 20, 2024
@kmaehashi kmaehashi added cat:enhancement Improvements to existing features prio:high labels Dec 20, 2024
@kmaehashi
Copy link
Member

Thanks @cjnolet, LGTM!

Could you bump the base Docker image to the one with cuVS (I guess 24.12-cuda12.0-py3.10?) Then /test rapids can trigger the CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:enhancement Improvements to existing features prio:high to-be-backported Pull-requests to be backported to stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Update cuPy to use cuvs.distance
4 participants