-
-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating pylibraft pairwise_distance
to cuvs
#8847
Open
cjnolet
wants to merge
8
commits into
cupy:main
Choose a base branch
from
cjnolet:update_pylibraft_to_cuvs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+74
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ards compatible with pylibraft when appropriate)
bdice
reviewed
Dec 19, 2024
tests/cupyx_tests/scipy_tests/spatial_tests/test_kdtree_cuvs.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Bradley Dice <[email protected]>
I assume these two files will need to change too, in order to test this in the CI: |
leofang
added
the
to-be-backported
Pull-requests to be backported to stable branch
label
Dec 20, 2024
Thanks @cjnolet, LGTM! Could you bump the base Docker image to the one with cuVS (I guess |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cat:enhancement
Improvements to existing features
prio:high
to-be-backported
Pull-requests to be backported to stable branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates cupy so that it can make use of the cuvs library for pairwise distance, which the vector search APIs from pylibraft have recently moved. This PR maintains the backwards compatibility with pylibraft while will exposing double precision float support.
Closes rapidsai/cuvs#542