Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kmeans test is flaky due to custom make-blobs being random #1

Open
seberg opened this issue Nov 12, 2024 · 0 comments
Open

kmeans test is flaky due to custom make-blobs being random #1

seberg opened this issue Nov 12, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@seberg
Copy link
Contributor

seberg commented Nov 12, 2024

The kmeans test is still somewhat flaky and sometimes fails. We can reduce the number of clusters, dimensions, etc. to ensure better convergence. Maybe sorting the centers may also help, but not sure it is likely that two centers swap in the first dimension. (the current code sorts the first dimension to match centers, rather than finding the best matches. That is because the center order itself is random).

Alternatively, and maybe better may be to see if we can't just stability the random-ness. And one easy way to do so to not use the custom make-blobs, but instead use sklearns one.

@seberg seberg added the bug Something isn't working label Nov 12, 2024
@seberg seberg transferred this issue from another repository Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant