Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

picotool uf2 convert --verbose option doesn't work #185

Closed
richard9999999999 opened this issue Nov 28, 2024 · 3 comments · Fixed by #186
Closed

picotool uf2 convert --verbose option doesn't work #185

richard9999999999 opened this issue Nov 28, 2024 · 3 comments · Fixed by #186

Comments

@richard9999999999
Copy link

picotool uf2 convert --verbose option doesn't work for me

@lurch
Copy link
Contributor

lurch commented Nov 28, 2024

Can you please give more details, e.g. what did you expect to happen, and what actually happened? And did you see any error messages?

@richard9999999999
Copy link
Author

richard9999999999 commented Nov 28, 2024

OK, if you look into elf2uf2.cpp, you see variable:

static bool verbose;

and code snippets like:

if (verbose) {
                if (ram_style) {
                    printf("Detected RAM binary\n");
                } else {
                    printf("Detected FLASH binary\n");
                }
            }

when you run picotool uf2 convert, you see description:

SYNOPSIS:
    picotool uf2 convert [--quiet] [--verbose] <infile> [-t <type>] <outfile> [-t <type>] [-o <offset>] [--family
                <family_id>] [[--abs-block] [<abs_block_loc>]]

However usage of --verbose parameter changes nothing: you do not see additional info about conversion in the console (that parameter is not set to that static bool verbose)

(edited by lurch to add backticks)

will-v-pi added a commit that referenced this issue Nov 29, 2024
Pass the settings.verbose setting to elf2uf2.cpp functions, to add verbose output to picotool uf2 convert

Fixes #185
@will-v-pi will-v-pi linked a pull request Dec 4, 2024 that will close this issue
will-v-pi added a commit that referenced this issue Dec 4, 2024
Pass the settings.verbose setting to elf2uf2.cpp functions, to add verbose output to picotool uf2 convert

Fixes #185
@will-v-pi
Copy link
Contributor

Merged into develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants