Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No spectrum provided for Material pseudocumene despite having a re-emission probability #119

Open
JamesJieranShen opened this issue Jan 4, 2024 · 1 comment
Assignees

Comments

@JamesJieranShen
Copy link
Contributor

See: https://github.com/rat-pac/ratpac-two/blob/8883adc556ec714fc6b129ad76f6378a7ed2ba0b/ratdb/OPTICS.ratdb#L426-L436C1

This is undefined behavior. I think pseudocumene is a solvent that does not scintillate itself. In that case, the re-emission probability should be removed.

@tannerbk
Copy link
Contributor

tannerbk commented Feb 3, 2024

It looks like these generic scintillator materials are not implemented well, or are out-of-date. For example, are these values used anywhere?

https://github.com/rat-pac/ratpac-two/blob/8883adc556ec714fc6b129ad76f6378a7ed2ba0b/ratdb/OPTICS.ratdb#L444-L449

It may be best these materials, and replace them with a single material "scintillator" with properties that come from documented, publically available measurements (perhaps for LAB).

@tannerbk tannerbk self-assigned this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants