Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing data (fits images) for S5.2 #88

Open
timstaley opened this issue Sep 6, 2016 · 3 comments
Open

Missing data (fits images) for S5.2 #88

timstaley opened this issue Sep 6, 2016 · 3 comments

Comments

@timstaley
Copy link
Contributor

The 'data/fits' folder is used a lot for the 'Sampling and Point Spread Functions' section, but has not been committed.

A quick suggestion - if you're going to add a significant amount of binary-blob data, you might want to add it as a git submodule, so that checking out the original git repository doesn't require an initial large download. On the other hand, submodules add complexity and help to confuse newcomers, so, pros and cons.

@griffinfoster
Copy link
Collaborator

Yeah, this is a problem in which I haven't decided on a solution to. Currently, there is a link to the files (http://www.mth.uct.ac.za/~siphelo/admin/interferometry/data/fundamentals_fits.tar.gz) and some notes in the readme on where to include the files.

A git submodule is a good idea I hadn't thought of. There is also the github lfs extension.

@timstaley
Copy link
Contributor Author

timstaley commented Sep 8, 2016

Ah, I should have RTFM (aka. Read The Fine Readme). Ta :-)

griffinfoster pushed a commit that referenced this issue Mar 6, 2017
Automatic referencing updates
@lao19881213
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants