From 8aa86e070c6e546e363e7d361e7339806c3e0a78 Mon Sep 17 00:00:00 2001 From: Patlola Date: Wed, 8 Jul 2020 19:37:28 +0000 Subject: [PATCH] added some new banks --- scraper/scripts/methods.rb | 2 +- src/banknames.json | 3 +++ src/php/Bank.php | 3 +++ src/ruby/bank.rb | 4 ++++ tests/php/CoverageTest.php | 2 +- 5 files changed, 12 insertions(+), 2 deletions(-) diff --git a/scraper/scripts/methods.rb b/scraper/scripts/methods.rb index 5c26c695..26855c3f 100644 --- a/scraper/scripts/methods.rb +++ b/scraper/scripts/methods.rb @@ -97,7 +97,7 @@ def parse_rtgs(banks) # There is a second header in the middle of the sheet. # :facepalm: RBI - next if row['IFSC'].nil? or ['IFSC_CODE', 'BANK OF BARODA', ''].include?(row['IFSC']) + next if row['IFSC'].nil? or ['IFSC_CODE', 'BANK OF BARODA', '', 'KPK HYDERABAD'].include?(row['IFSC']) original_ifsc = row['IFSC'] row['IFSC'] = row['IFSC'].upcase.gsub(/[^0-9A-Za-z]/, '').strip diff --git a/src/banknames.json b/src/banknames.json index a24207c6..d9ed2ca5 100644 --- a/src/banknames.json +++ b/src/banknames.json @@ -997,6 +997,7 @@ "RSBL": "Rajgurunagar Sahakari Bank", "RSBX": "Raigad Sahakari Bank", "RSCB": "Rajasthan State Co-operative Bank", + "RSSB": "Rajarshi Shahu Sahakari Bank", "RSSX": "Rajarshi Shahu Sahakari Bank", "RSUX": "Radhasoami Urban Co-operative Bank", "RSVX": "Rajarshi Shahu Govt Servants Co-operative Bank Kolh", @@ -1169,6 +1170,7 @@ "SUNB": "Surat National Co-operative Bank", "SURX": "Siddheshwar Urban Co-operative Bank Maryadit Sillod", "SURY": "Suryoday Small Finance Bank", + "SUSB": "Suco Souharda Sahakari Bank", "SUSX": "Sirsi Urban Sahakari Bank", "SUTB": "Sutex Co-operative Bank", "SUVX": "Suvarnayug Sahakari Bank", @@ -1346,6 +1348,7 @@ "UTKS": "Utkarsh Small Finance Bank", "UTKX": "Uttarakhand State Co-operative Bank", "UTZX": "Uttarkashi Zila Sahkari Bank", + "UUCB": "Udaipur Urban Co-operative Bank", "UUCX": "Udaipur Urban Co-operative Bank", "VADX": "Valsad District Central Co-operative Bank", "VAIX": "Vaishya Sahakari Bank Mumbai", diff --git a/src/php/Bank.php b/src/php/Bank.php index d246fa57..64be9c23 100644 --- a/src/php/Bank.php +++ b/src/php/Bank.php @@ -1001,6 +1001,7 @@ class Bank const RSBL = 'RSBL'; const RSBX = 'RSBX'; const RSCB = 'RSCB'; + const RSSB = 'RSSB'; const RSSX = 'RSSX'; const RSUX = 'RSUX'; const RSVX = 'RSVX'; @@ -1173,6 +1174,7 @@ class Bank const SUNB = 'SUNB'; const SURX = 'SURX'; const SURY = 'SURY'; + const SUSB = 'SUSB'; const SUSX = 'SUSX'; const SUTB = 'SUTB'; const SUVX = 'SUVX'; @@ -1350,6 +1352,7 @@ class Bank const UTKS = 'UTKS'; const UTKX = 'UTKX'; const UTZX = 'UTZX'; + const UUCB = 'UUCB'; const UUCX = 'UUCX'; const VADX = 'VADX'; const VAIX = 'VAIX'; diff --git a/src/ruby/bank.rb b/src/ruby/bank.rb index 07ffc0f4..fb7df1ee 100644 --- a/src/ruby/bank.rb +++ b/src/ruby/bank.rb @@ -576,6 +576,7 @@ module Bank KATX = :KATX KAYX = :KAYX KBCX = :KBCX + KBKB = :KBKB KBNX = :KBNX KBSX = :KBSX KCBL = :KCBL @@ -999,6 +1000,7 @@ module Bank RSBL = :RSBL RSBX = :RSBX RSCB = :RSCB + RSSB = :RSSB RSSX = :RSSX RSUX = :RSUX RSVX = :RSVX @@ -1171,6 +1173,7 @@ module Bank SUNB = :SUNB SURX = :SURX SURY = :SURY + SUSB = :SUSB SUSX = :SUSX SUTB = :SUTB SUVX = :SUVX @@ -1348,6 +1351,7 @@ module Bank UTKS = :UTKS UTKX = :UTKX UTZX = :UTZX + UUCB = :UUCB UUCX = :UUCX VADX = :VADX VAIX = :VAIX diff --git a/tests/php/CoverageTest.php b/tests/php/CoverageTest.php index d2ae0603..2ba1fd0c 100644 --- a/tests/php/CoverageTest.php +++ b/tests/php/CoverageTest.php @@ -38,7 +38,7 @@ public function testNames() { // For some reason the CSV header is picked up as a IFSC code // Skip the check while this is fixed. - $exceptions = ['IFSC']; + $exceptions = ['IFSC', 'KPKH']; foreach ($this->bankCodes as $code) { if (!in_array($code, $exceptions))