From ead204d73d9bcd24d567b67da9b3e109c9545ff0 Mon Sep 17 00:00:00 2001 From: Nemo Date: Mon, 30 Dec 2019 20:09:04 +0530 Subject: [PATCH] Adds ILCB to bank lists --- src/banknames.json | 1 + src/php/Bank.php | 1 + src/ruby/bank.rb | 1 + tests/php/CoverageTest.php | 3 ++- 4 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/banknames.json b/src/banknames.json index e877fb84..843862c9 100644 --- a/src/banknames.json +++ b/src/banknames.json @@ -435,6 +435,7 @@ "IDIB": "Indian Bank", "IDUK": "Idukki District Co-operative Bank", "IDUX": "Idukki District Co-operative Bank", + "ILCB": "Ilkal Co-operative Bank", "IMPX": "Imphal Urban Co-operative Bank", "INCX": "Indapur Urban Co-operative Bank", "INDB": "Indusind Bank", diff --git a/src/php/Bank.php b/src/php/Bank.php index a21cd2d0..e566bc74 100644 --- a/src/php/Bank.php +++ b/src/php/Bank.php @@ -438,6 +438,7 @@ class Bank const IDIB = 'IDIB'; const IDUK = 'IDUK'; const IDUX = 'IDUX'; + const ILCB = 'ILCB'; const IMPX = 'IMPX'; const INCX = 'INCX'; const INDB = 'INDB'; diff --git a/src/ruby/bank.rb b/src/ruby/bank.rb index 601aa410..bf2d1f3d 100644 --- a/src/ruby/bank.rb +++ b/src/ruby/bank.rb @@ -433,6 +433,7 @@ module Bank IDIB = :IDIB IDUK = :IDUK IDUX = :IDUX + ILCB = :ILCB IMPX = :IMPX INCX = :INCX INDB = :INDB diff --git a/tests/php/CoverageTest.php b/tests/php/CoverageTest.php index 73fe68c1..ed8fa3ad 100644 --- a/tests/php/CoverageTest.php +++ b/tests/php/CoverageTest.php @@ -174,13 +174,14 @@ public function testPatches() foreach ($yaml['ifsc'] as $code) { - if (IFSC::validate($code) !== true) + if (IFSC::validate($code) !== true and $yaml['action'] != 'delete') { $failures[] = $code; } } } + // BANKOFBAROD is an invalid code, so it is marked as an exception $this->assertEquals([], $failures, "IFSC codes present in patches, but fails validation"); } }