Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build is currently failing #121

Closed
flyingcircle opened this issue Dec 23, 2021 · 10 comments · Fixed by #122
Closed

Build is currently failing #121

flyingcircle opened this issue Dec 23, 2021 · 10 comments · Fixed by #122

Comments

@flyingcircle
Copy link
Contributor

https://github.com/react-native-elements/playground/actions/runs/1616009494

I think this is likely due to some of the props changes that we've made in RNE.

@jugshaurya perhaps you have some insight to this?

@jugshaurya
Copy link
Contributor

jugshaurya commented Dec 23, 2021

@flyingcircle, I will look into it soon.
Btw, I solved this problem earlier via #97. But after the latest merges during GSoC 2021. Something else pushed and made my PRs, conflicting with master branch code, I will look into it.

@jugshaurya
Copy link
Contributor

@flyingcircle , I think the build is failing because file names are changed inside in website/docs/main folder of the react-native-elements repository, and react components of the playground are using the older filenames that were in the props/ folder.Will try to fix them all soon.

@flyingcircle
Copy link
Contributor Author

awesome thanks!

@jugshaurya
Copy link
Contributor

jugshaurya commented Dec 29, 2021

@flyingcircle, I figured out the problem. Actually, the playground needed Props of every component only, and the folder ./react-native-elements/website/docs/main contains them, but the MDX files contain the <Usage/> component which uses @theme/* components from react-native-elements, and since we don't have access to them in the playground we are getting the error.
3

Solution

  • To move all the props into a props folder like the usage folder and move content into respective files inside the props folder.
  • and importing respective props and using <Props /> just like we do with <Usage />.

endResult

  • **from this **
    1

  • to this
    2

  • and then copying props folder like we used to do.

  • what do you say? Should I continue? waiting for your response.

  • It will need two PRs

  1. moving content to props folder (in react-native-elements repository)
  2. fixing injectProps.js file to copy props folder (in playground repository.)

@flyingcircle
Copy link
Contributor Author

@arpitBhalla Might be relevant with the moving the packages around.

@arpitBhalla
Copy link
Member

arpitBhalla commented Dec 30, 2021

component which uses @theme/* components from react-native-elements,

No, actually these are being imported from docusaurus.

I have implemented playground editor in docusaurus docs, do we need this playground website separately now?

E.g. https://reactnativeelements.com/docs/next/avatar

@arpitBhalla
Copy link
Member

moving content to props folder (in react-native-elements repository)

Yupp, we can do it. I will make changes in another PR.

@arpitBhalla
Copy link
Member

@jugshaurya
Copy link
Contributor

jugshaurya commented Dec 30, 2021

moving content to props folder (in react-native-elements repository)

Yupp, we can do it. I will make changes in another PR.

@flyingcircle @arpitBhalla , I have done this moving part. Will make a PR soon.

@jugshaurya
Copy link
Contributor

@flyingcircle @arpitBhalla, I have moved content to the props folder and added the respective Props component to each file. please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants