Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global setting for disabling "Edit button" #1366

Open
benjaoming opened this issue Nov 1, 2022 · 0 comments · May be fixed by #1633
Open

Global setting for disabling "Edit button" #1366

benjaoming opened this issue Nov 1, 2022 · 0 comments · May be fixed by #1633
Labels
Feature New feature Good First Issue Good for new contributors Improvement Minor improvement to code

Comments

@benjaoming
Copy link
Contributor

People are having issues figuring out how to remove the "Edit on Github" button, and I would agree that it's cumbersome.

I don't think it's a good idea to remove it, but I'm sure people have their reasons.

The most straight-forward solution would probably be to respect the html_show_sourcelink setting.

See also: sphinx-doc/sphinx#2386
@benjaoming benjaoming added Improvement Minor improvement to code Feature New feature Good First Issue Good for new contributors labels Nov 1, 2022
@abitrolly abitrolly linked a pull request Dec 3, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature New feature Good First Issue Good for new contributors Improvement Minor improvement to code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Respect html_show_sourcelink setting abitrolly/sphinx_rtd_theme
1 participant
@benjaoming