You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Command args printer (as seen in otel db.statement) is obscure. even when queries are simple and human readable. this leads to problems with debugging.
Expected Behavior
query should be printed like *=>[KNN 10 @v $v
as produced by:
Current Behavior
Possible Solution
probably this code makes printing query into non-simple bytes (due to lack of whitespace or other symbols)
If otel db.statement is indeed shows exactly what is send over wire, maybe it is okay to keep it. but I doubt so. since this is conflicting with Redis syntax in docs.
importantly, Redis was designed to have API human readable. specifically query statements. now we are marshalling what is supposed to be human redable into non-readable binary? how come? when did we lose the plot?
Possible Implementation
review what is send on wire (if command is human readble indeed)
set otel to what is send on wire
The text was updated successfully, but these errors were encountered:
Command args printer (as seen in otel
db.statement
) is obscure. even when queries are simple and human readable. this leads to problems with debugging.Expected Behavior
query should be printed like
*=>[KNN 10 @v $v
as produced by:
Current Behavior
Possible Solution
probably this code makes printing query into non-simple bytes (due to lack of whitespace or other symbols)
https://github.com/redis/go-redis/blob/master/extra/rediscmd/rediscmd.go#L13
Steps to Reproduce
Context (Environment)
go redis module
Detailed Description
If otel
db.statement
is indeed shows exactly what is send over wire, maybe it is okay to keep it. but I doubt so. since this is conflicting with Redis syntax in docs.importantly, Redis was designed to have API human readable. specifically query statements. now we are marshalling what is supposed to be human redable into non-readable binary? how come? when did we lose the plot?
Possible Implementation
The text was updated successfully, but these errors were encountered: