Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC]: Add a config value to the redwood.toml to suppress storybook opening automatically #11752

Open
1 task done
Philzen opened this issue Dec 6, 2024 · 0 comments
Open
1 task done

Comments

@Philzen
Copy link
Contributor

Philzen commented Dec 6, 2024

Summary

We have a convenient

[browser]
  open = false

options so yarn rw dev won't automatically open a new browser tab on each execution.

It would be nice to have an equivalent for yarn rw sb. Obvious proposal: introduce the option

[storybook]
  open = false

into redwood.toml.

Motivation

Even when not trying to narrow down issues that require manual restarts (yes, looking at you #11742 🙊), or hunting down other potential issues (where one can never be sure having multiple tab instances open at the same time doesn't cause side-effects or breaks issue reproducibility): it's simply nice to be able to control in which browser, which window, and when you open the storybook.

Just as with the Redwood Dev server.

And as i'm too lazy to clutter my shell config with yet another alias but also to forgetful and lazy to add the --no-open flag to the command every time, having this configurable would be a nice improvement.

Detailed proposal

Have a config setting that will automatically pass --no-open flag to yarn rw sb.

For full disclosure, there currently exists a workaround by supplying BROWSER=true as an environment variable, but that is a (counter-intuitive and more or less accidental) feature disguised as a bug, disguised as a feature, which officially doesn't even exist … and hence can break anytime. Nothing you'd want to rely on.

Are you interested in working on this?

  • I'm interested in working on this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant