Images in /public not served on Vercel

[bennash]

I'm not getting vercel to show the images in the /public directory. Is there some config to set? thanks

[corwinm]

@bennash I was able to update my vercel/output/config.json and get images to load. I'm not sure if this is the best way to do this or if there is a downside but it got me past this issue.

{
  "version": 3,
  "routes": [
    {
      "src": "/favicon.ico",
      "dest": "/favicon.ico"
    },
    {
-      "src": "/assets/(.*)",
-      "dest": "/assets/$1"
+      "src": "/(.*)",
+      "dest": "/$1"
    },
    {
      "src": "/(.*)",
      "dest": "/"
    }
  ]
}

[brookslybrand]

Thanks @corwinm for the suggestion. I just merged in #60 which is based off your input. Key differences:

• Kept the /assets/ routing and added default caching to it (like in node-custom-server)
• Updated the route config below to be the catchall you provided

Also, @bennash, I generally recommend importing images directly (see the <Welcome /> component), since Vite will bundle them up and fingerprint them for you. But you do whatever works best for you

Thanks for opening the issue!

[brookslybrand]

Actually @corwinm I had to revert this in #62

I would recommend adding something like this to vercel/output/config.json:

  {
    "src": "/pics/(.*)",
    "dest": "/pics/$1"
  },

Basically you just need to let Vercel know requests you dont' want to be handled by React Router directly

[corwinm]

Thanks @brookslybrand! I'll have to update my config later and see how it goes. I like the idea of having the public folder "just work" but I can also understand the need to have restrictions here and more control over cache. I think my use case was centered around a site.manifest and the icons there. Thats easy enough to configure to work but in an ideal world anything in the public directory would be public.
Not sure if this is a common enough use case to warrant a section in the README but I wouldn't say it is straight forward.
Also a bit unfortunate that you wouldn't run into this locally and it would only be after it is deployed, but we all are deploying to branches and testing before we push to prod right? ...Right?