Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove type from favorite #143

Open
simonv3 opened this issue Oct 31, 2022 · 0 comments
Open

Remove type from favorite #143

simonv3 opened this issue Oct 31, 2022 · 0 comments
Labels
post-migration

Comments

@simonv3
Copy link
Collaborator

simonv3 commented Oct 31, 2022

Right now on the favorite table we store whether the song is favorited in the type column, whereas it seems like we should just delete that instance. Seems like it's creating two ways of determing if a song is unfavorited or not (it's either type: false or non-existent).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
post-migration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonv3