Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

member information is duplicated in users.members and user_memberships table. #161

Open
simonv3 opened this issue Nov 8, 2022 · 1 comment

Comments

@simonv3
Copy link
Collaborator

simonv3 commented Nov 8, 2022

users.members is a boolean, while the user_memberships table is associated to stripe subscriptions.

I'm guessing that users.member is meant to capture old members from before the transition to user-api. However it's got no time frame associated with it so we should probably just use the user_memberships table.

Edit: to clarify it looks like users.member table is a check to verify that a user is a music making member. Again, this probably should be automatically calculated based on if someone has just uploaded a track to Resonate (which is what it does in that migration script), rather than stashed.

But since there's no way to manually keep track of worker members (except for on the Discourse) we can keep the user.member column and use it for that. The other two memberships should be calculated automatically though.

@simonv3 simonv3 added this to the Merge Complete milestone Nov 8, 2022
@simonv3 simonv3 added the discussion-needed We need to discuss this label Nov 8, 2022
@simonv3
Copy link
Collaborator Author

simonv3 commented Nov 10, 2022

we decided that the members column was legacy information that we would keep toggled for now, but that we would eventually use it to indicate worker members.

@simonv3 simonv3 removed the discussion-needed We need to discuss this label Nov 16, 2022
@simonv3 simonv3 removed this from the Merge Complete milestone Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant