Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] - Change mining key encryption type #1854

Open
Tr43212 opened this issue Jan 27, 2025 · 3 comments
Open

[Feature request] - Change mining key encryption type #1854

Tr43212 opened this issue Jan 27, 2025 · 3 comments

Comments

@Tr43212
Copy link

Tr43212 commented Jan 27, 2025

Description:
Replaces Base64 encoding with SHA-256 hashing for enhanced security.

Implementation Details:
Replace "base64" module with "hashlib" module.

Reason for Change:
Base64 is not secure, while SHA-256 provides a secure, non-reversible hash suitable for sensitive data.

Cons:
Make the users enter the mining key everytime they want to start a new mining sesssion

@profpandaa
Copy link
Contributor

A hash is unsuited for this application. An encryption standard would be a better fit.

@JK-Rolling
Copy link
Collaborator

I think OP is referring to the mining key encryption where the encrypted key is stored in Settings.cfg by python miner

@profpandaa
Copy link
Contributor

Still, a hash is unsuited. If you have to re-enter the mining key with every start anyway, why even save it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants