Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Performance Improvement: matmul vs dot vs einsum #58

Open
rickvanveen opened this issue Apr 23, 2021 · 0 comments
Open

Possible Performance Improvement: matmul vs dot vs einsum #58

rickvanveen opened this issue Apr 23, 2021 · 0 comments
Assignees

Comments

@rickvanveen
Copy link
Owner

rickvanveen commented Apr 23, 2021

Is your feature request related to a problem? Please describe.
Not a problem just enhancement. Should check if there is a possible performance gain (probably mostly in the distance function) when changing any of the dot products to matmul or better einsums. Furthermore changing certain dot calls to matmul makes it more clear what is going on for anyone not that familiar with numpy.

Describe the solution you'd like
Change dot function to better einsum or matmul calls.

Describe alternatives you've considered
n/a

Additional context

  • matmul is faster for larger matrices.
  • dot is faster for smaller matrices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant