Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing features #22

Open
3 of 5 tasks
bkniffler opened this issue Jun 18, 2018 · 1 comment
Open
3 of 5 tasks

Missing features #22

bkniffler opened this issue Jun 18, 2018 · 1 comment

Comments

@bkniffler
Copy link
Contributor

bkniffler commented Jun 18, 2018 •
edited by rkazakov
Loading

Hey, nice work on ampify, but there is still some issues:

  • Take care of css inside of <style> tags
  • Concat all custom styles to a single <style>
  • Remove <script> tags
  • Remove inline-styles
  • Add to link to original url, maybe get url from a second argument to ampify(html, originalURL)
blanxii pushed a commit to blanxii/ampify that referenced this issue Oct 1, 2018
feature(MultipleCssFiles) rkazakov#22 Concat all custom styles to a s…
78eae92 
…ingle <style>
blanxii pushed a commit to blanxii/ampify that referenced this issue Oct 1, 2018
feature(MultipleCssFiles) rkazakov#22 Concat all custom styles to a s…
df07c71 
…ingle <style>
@blanxii
Copy link
Contributor

blanxii commented Oct 1, 2018

Is the remove script tags something we want to do? Could change all the behaviour of the app, ofc we can just trim them and that's all.. but adding warning or something like that? also I'll suggest create tickets for each feature.

blanxii pushed a commit to blanxii/ampify that referenced this issue Oct 1, 2018
feature(CannonicalURL) rkazakov#22 Add support for cannonical URL as …
c6ee133 
…a new parameter
@blanxii blanxii mentioned this issue Oct 1, 2018
Merged
blanxii pushed a commit to blanxii/ampify that referenced this issue Oct 1, 2018
feature(CannonicalURL) rkazakov#22 Update readme with documentation
7d7a5a5
blanxii pushed a commit to blanxii/ampify that referenced this issue Oct 1, 2018
feature(RemoveInlineCss) rkazakov#22 Remove inline css for all elements
9a667d9
rkazakov pushed a commit that referenced this issue Jun 30, 2022
@rkazakov
feature(RemoveInlineCss) #22 Remove inline css for all elements
a21cac0
rkazakov added a commit that referenced this issue Jul 1, 2022
@rkazakov
feature(CannonicalURL) #22 Add support for cannonical URL (#27)
e813f1a 
* feature(CannonicalURL) #22 Add support for cannonical URL as a new parameter

* feature(CannonicalURL) #22 Update readme with documentation

Co-authored-by: Ruslan Kazakov <[email protected]>
rkazakov added a commit that referenced this issue Jul 1, 2022
@rkazakov
feature(MultipleCssFiles) #22 Concat all custom styles to a single (#26)
cf43fc1 
* feature(MultipleCssFiles) #22 Concat all custom styles to a single <style>

* feature(MultipleCssFiles) #22 Concat all custom styles to a single <style>

Co-authored-by: Ruslan Kazakov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bkniffler @blanxii