Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Change in List dialog #60

Open
ethanstrominger opened this issue Jan 1, 2021 · 4 comments
Open

UI: Change in List dialog #60

ethanstrominger opened this issue Jan 1, 2021 · 4 comments

Comments

@ethanstrominger
Copy link

ethanstrominger commented Jan 1, 2021

  • options for search field:
    • add a drop down with two choices: All Github or Current Repo. If that is too difficult, add a title to the dialog box indicating which list.
    • add a checkbox, Current Repository Only
    • improve hint text: Seach for users in current repository or Search all github users
  • add two buttons to each user:
    • a + to add a person to the Co-authors section
    • a heart to add a person to the favorites section
  • consider not closing list when a user is selected to allow for selecting multiple or to add to both favorites and co-authors. I don't know if that would improve the UI or not.
@rkotze
Copy link
Owner

rkotze commented Jan 1, 2021

I'd like to understand more about where you want to add this drop-down?

Currently, there is a dropdown under the ellipsis providing the two options.

image

@ethanstrominger
Copy link
Author

The drop down would appear to the right of where you enter the person's name.

image

IMO if hard, not worth it, if easy would be an improvement.

@rkotze
Copy link
Owner

rkotze commented Jan 4, 2021

I think with the dropdown it will always appear at the top. Don't think VS Code API lets you position the dropdown contextually.

@ethanstrominger
Copy link
Author

Maybe add something above? Or easier, change the hint text. I added options to the top, if hint text can be changed that would be okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants