Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Unresolved reference: allowOverlapWithPuck #3245

Closed
andrei-tofan opened this issue Dec 6, 2023 · 3 comments · Fixed by #3247
Closed

[Bug]: Unresolved reference: allowOverlapWithPuck #3245

andrei-tofan opened this issue Dec 6, 2023 · 3 comments · Fixed by #3247
Labels
bug 🪲 Something isn't working

Comments

@andrei-tofan
Copy link
Contributor

Mapbox Implementation

Mapbox

Mapbox Version

default

Platform

Android

@rnmapbox/maps version

10.1.0-rc.3

Standalone component to reproduce

import React from 'react';
import {
  MapView,
  ShapeSource,
  LineLayer,
  Camera,
} from '@rnmapbox/maps';

const aLine = {
  type: 'LineString',
  coordinates: [
    [-74.00597, 40.71427],
    [-74.00697, 40.71527],
  ],
};

class BugReportExample extends React.Component {
  render() {
    return (
      <MapView style={{flex: 1}}>
        <Camera centerCoordinate={[-74.00597, 40.71427]} zoomLevel={14} />
        <ShapeSource id="idStreetLayer" shape={aLine}>
          <LineLayer id="idStreetLayer" />
        </ShapeSource>
      </MapView>
    );
  }
}

Observed behavior and steps to reproduce

When executing react-native run-android the latest RC android build fails with error:

Note: Recompile with -Xlint:unchecked for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /Users/andrei/Projects/liapp2/node_modules/react-native-reanimated/android/src/main/java/com/swmansion/reanimated/NodesManager.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
e: /Users/andrei/Projects/liapp2/node_modules/@rnmapbox/maps/android/src/main/java/com/rnmapbox/rnmbx/components/annotation/RNMBXMarkerView.kt: (186, 13): Unresolved reference: allowOverlapWithPuck

FAILURE: Build failed with an exception.

Expected behavior

The previous RC 10.1.0-rc.2 works, but the latest one fails with the error above.

Notes / preliminary analysis

No response

Additional links and references

No response

@andrei-tofan andrei-tofan added the bug 🪲 Something isn't working label Dec 6, 2023
@andrei-tofan andrei-tofan changed the title [Bug]: nresolved reference: allowOverlapWithPuck [Bug]: Unresolved reference: allowOverlapWithPuck Dec 6, 2023
@mfazekas
Copy link
Contributor

mfazekas commented Dec 6, 2023

@andrei-tofan thanks much. Interesting somehow our CI haven't caught this -

https://github.com/rnmapbox/maps/actions/runs/7106529907/job/19346258220

But I do see it locally:

Unresolved reference: allowOverlapWithPuck

@MichaelDanielTom FYI

@MichaelDanielTom
Copy link
Contributor

MichaelDanielTom commented Dec 6, 2023

My bad, still getting used to the testing flow and didn't test on android with v10, thanks for the quick fix @mfazekas

@mfazekas
Copy link
Contributor

mfazekas commented Dec 6, 2023

@MichaelDanielTom it was my bad, as I've shadowed the v11 variable and CI builded only v11 variants...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants