Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: incompatiblity with [email protected]/3.4.0 #3650

Closed
efstathiosntonas opened this issue Oct 10, 2024 · 3 comments
Closed

[Bug]: incompatiblity with [email protected]/3.4.0 #3650

efstathiosntonas opened this issue Oct 10, 2024 · 3 comments
Labels
bug 🪲 Something isn't working reopen-on-code-fixed

Comments

@efstathiosntonas
Copy link

efstathiosntonas commented Oct 10, 2024

Mapbox Implementation

Mapbox

Mapbox Version

11.6.0

React Native Version

0.75.4

Platform

Android

@rnmapbox/maps version

10.1.31

[email protected] will probably land on [email protected] according to this PR: facebook/react-native#46864

edit node_modules/react-native/gradle/libs.versions.toml -> set fresco = "3.3.0" -> build fails:

> Task :rnmapbox_maps:compileDebugKotlin
e: file:///Users/stathis/IdeaProjects/APP_NAME_mobile/node_modules/@rnmapbox/maps/android/src/main/java/com/rnmapbox/rnmbx/components/mapview/RNMBXMapView.kt:18:27 Unresolved reference: ViewTreeLifecycleOwner
e: file:///Users/stathis/IdeaProjects/APP_NAME_mobile/node_modules/@rnmapbox/maps/android/src/main/java/com/rnmapbox/rnmbx/components/mapview/RNMBXMapView.kt:119:30 Object is not abstract and does not implement abstract member public abstract val lifecycle: Lifecycle defined in com.rnmapbox.rnmbx.components.mapview.RNMBXLifeCycleOwner
e: file:///Users/stathis/IdeaProjects/APP_NAME_mobile/node_modules/@rnmapbox/maps/android/src/main/java/com/rnmapbox/rnmbx/components/mapview/RNMBXMapView.kt:134:17 'getLifecycle' overrides nothing
e: file:///Users/stathis/IdeaProjects/APP_NAME_mobile/node_modules/@rnmapbox/maps/android/src/main/java/com/rnmapbox/rnmbx/components/mapview/RNMBXMapView.kt:138:13 Unresolved reference: ViewTreeLifecycleOwner
e: file:///Users/stathis/IdeaProjects/APP_NAME_mobile/node_modules/@rnmapbox/maps/android/src/main/java/com/rnmapbox/rnmbx/components/styles/RNMBXStyleImport.kt:9:37 Unresolved reference: style
e: file:///Users/stathis/IdeaProjects/APP_NAME_mobile/node_modules/@rnmapbox/maps/android/src/main/java/com/rnmapbox/rnmbx/components/styles/layers/RNMBXLayer.kt:21:37 Unresolved reference: layer

> Task :rnmapbox_maps:compileDebugKotlin FAILED

downgrading [email protected] builds fine.

remarks:

  1. I build rn on Android from source
  2. tried to clean gradle, same results
@efstathiosntonas efstathiosntonas added the bug 🪲 Something isn't working label Oct 10, 2024
@efstathiosntonas
Copy link
Author

Hey guys, not a big deal for now but we might face this in the future, this is just a "proactive" bug report.

@efstathiosntonas
Copy link
Author

efstathiosntonas commented Oct 18, 2024

@mfazekas hi, this should not be closed, [email protected] is coming soon.

@efstathiosntonas efstathiosntonas changed the title [Bug]: incompatiblity with [email protected] [Bug]: incompatiblity with [email protected]/3.4.0 Oct 18, 2024
Copy link

No code example found in issue body - More info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working reopen-on-code-fixed
Projects
None yet
Development

No branches or pull requests

1 participant