Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations for Flarum 2.0 premium extensions are fetched to Flarum 1.0 instance #45

Open
2 tasks
rob006 opened this issue Dec 21, 2024 · 0 comments
Open
2 tasks
Assignees
Labels
bug Something isn't working

Comments

@rob006
Copy link
Member

rob006 commented Dec 21, 2024

https://github.com/rob006-software/flarum-translations/commits/master/?author=robbot006&since=2024-12-21&until=2024-12-21

To fix this:

  • https://github.com/flarum-com/premium-translations would need to have separate branches for Flarum 1 and Flarum 2
  • Currently used API endpoint (https://flarum.org/api/extensions?filter[is][]=premium&page[limit]=100) would need to have additional param for specifying Flarum version
@rob006 rob006 added the bug Something isn't working label Dec 21, 2024
@rob006 rob006 self-assigned this Dec 21, 2024
rob006 added a commit that referenced this issue Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant