Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update interval in seconds #158

Open
serrj-sv opened this issue Feb 20, 2023 · 4 comments
Open

Update interval in seconds #158

serrj-sv opened this issue Feb 20, 2023 · 4 comments
Labels
new-feature New features or options. no-stale This issue or PR is exempted from the stable bot.

Comments

@serrj-sv
Copy link

Hi! My inverter supports TCP mode and I'd like to query it more frequently. Could you make it possible to set minimum update interval in seconds instead of minutes? I believe this cam be done by replacing minutes with seconds here: https://github.com/robbinjanssen/home-assistant-omnik-inverter/blob/main/custom_components/omnik_inverter/coordinator.py#L52

@robbinjanssen robbinjanssen added the new-feature New features or options. label Feb 21, 2023
@robbinjanssen
Copy link
Owner

Yes we can do that, I have to find out how to migrate the "previous" config from minutes to seconds though.

@MarijnS95
Copy link
Collaborator

FYI I'm working on a change that keeps the TCP connection open, where the inverter will send an update every minute (observed on a 3000TL) but have not yet found a way to change that rate.

Perhaps we should keep that as a separate configurable mode, to support both local_polling (also needed for the JS/HTML variants) and local_push?

@github-actions
Copy link

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Mar 24, 2023
@robbinjanssen robbinjanssen added no-stale This issue or PR is exempted from the stable bot. and removed stale There has not been activity on this issue or PR for quite some time. labels Mar 24, 2023
@GelsemaP
Copy link

isnt the code missing to store the time between updates in config? in strings i dont see the config key for timedelta.
also it seems that supporting seconds instead of minutes is just a matter of changing the timedelta to seconds. only concern is that with an update minutes are suddenly seconds, which you could fix by adding code for an update that rewrites the value. perhaps even add an extra field which allows you to use the timedelta as variable (minutes/seconds) as dropbox and use that for your timedelta command. I'm not that good in coding so cant try myself... sorry...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature New features or options. no-stale This issue or PR is exempted from the stable bot.
Projects
None yet
Development

No branches or pull requests

4 participants